pi-lens/rules/tree-sitter-queries/java/junit-call-super.yml

Real-time code feedback for pi — LSP, linters, formatters, type-checking, structural analysis & booboo

# JUnit Call Super
# Detects JUnit test cases that should call super methods
id: junit-call-super
name: JUnit Test Cases Should Call Super Methods
severity: error
category: maintainability
defect_class: correctness
inline_tier: blocking
language: java

message: "JUnit test case should call super method"

description: |
  When overriding setUp(), tearDown(), or other JUnit lifecycle
  methods, always call super.method() to ensure proper initialization
  and cleanup from parent classes.

  ✅ FIX: Call super method at start or end

  ```java
  @Override
  protected void setUp() throws Exception {
      super.setUp();  // GOOD - call super first
      // custom setup
  }
  ```

query: |
  (method_declaration
    (modifiers
      (marker_annotation
        name: (identifier) @OVERRIDE))
    name: (identifier) @METHOD
    body: (block) @BODY
    (#eq? @OVERRIDE "Override")
    (#match? @METHOD "^(setUp|tearDown|setUpBeforeClass|tearDownAfterClass)$"))

metavars:
  - OVERRIDE
  - METHOD
  - BODY

post_filter: missing_super_call

tags:
  - maintainability
  - java
  - junit
  - testing

examples:
  bad: |
    @Override
    protected void setUp() throws Exception {
        // custom setup  // BAD - missing super.setUp()
    }

  good: |
    @Override
    protected void setUp() throws Exception {
        super.setUp();  // GOOD - call super first
        // custom setup
    }

has_fix: false