eslint-plugin-unicorn-x/rules/prefer-reflect-apply.js

More than 100 powerful ESLint rules

import {getPropertyName} from '@eslint-community/eslint-utils';
import {isNullLiteral, isMethodCall} from './ast/index.js';

const MESSAGE_ID = 'prefer-reflect-apply';
const messages = {
	[MESSAGE_ID]: 'Prefer `Reflect.apply()` over `Function#apply()`.',
};

const isApplySignature = (argument1, argument2) =>
	(isNullLiteral(argument1) || argument1.type === 'ThisExpression') &&
	(argument2.type === 'ArrayExpression' ||
		(argument2.type === 'Identifier' && argument2.name === 'arguments'));

const getReflectApplyCall = (sourceCode, target, receiver, argumentsList) =>
	`Reflect.apply(${sourceCode.getText(target)}, ${sourceCode.getText(receiver)}, ${sourceCode.getText(argumentsList)})`;

const fixDirectApplyCall = (node, sourceCode) => {
	if (
		getPropertyName(node.callee) === 'apply' &&
		node.arguments.length === 2 &&
		isApplySignature(node.arguments[0], node.arguments[1])
	) {
		return (fixer) =>
			fixer.replaceText(
				node,
				getReflectApplyCall(
					sourceCode,
					node.callee.object,
					node.arguments[0],
					node.arguments[1],
				),
			);
	}
};

const fixFunctionPrototypeCall = (node, sourceCode) => {
	if (
		getPropertyName(node.callee) === 'call' &&
		getPropertyName(node.callee.object) === 'apply' &&
		getPropertyName(node.callee.object.object) === 'prototype' &&
		node.callee.object.object.object?.type === 'Identifier' &&
		node.callee.object.object.object.name === 'Function' &&
		node.arguments.length === 3 &&
		isApplySignature(node.arguments[1], node.arguments[2])
	) {
		return (fixer) =>
			fixer.replaceText(
				node,
				getReflectApplyCall(
					sourceCode,
					node.arguments[0],
					node.arguments[1],
					node.arguments[2],
				),
			);
	}
};

/** @param {import('eslint').Rule.RuleContext} context */
const create = (context) => ({
	CallExpression(node) {
		if (
			!isMethodCall(node, {
				optionalCall: false,
				optionalMember: false,
			}) ||
			node.callee.object.type === 'Literal' ||
			node.callee.object.type === 'ArrayExpression' ||
			node.callee.object.type === 'ObjectExpression'
		) {
			return;
		}

		const {sourceCode} = context;
		const fix =
			fixDirectApplyCall(node, sourceCode) ||
			fixFunctionPrototypeCall(node, sourceCode);
		if (fix) {
			return {
				node,
				messageId: MESSAGE_ID,
				fix,
			};
		}
	},
});

/** @type {import('eslint').Rule.RuleModule} */
const config = {
	create,
	meta: {
		type: 'suggestion',
		docs: {
			description: 'Prefer `Reflect.apply()` over `Function#apply()`.',
			recommended: true,
		},
		fixable: 'code',
		messages,
	},
};

export default config;