eslint-plugin-sonarjs
Version:
SonarJS rules for ESLint
78 lines (77 loc) • 3.36 kB
JavaScript
/*
* SonarQube JavaScript Plugin
* Copyright (C) 2011-2025 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the Sonar Source-Available License Version 1, as published by SonarSource SA.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
* See the Sonar Source-Available License for more details.
*
* You should have received a copy of the Sonar Source-Available License
* along with this program; if not, see https://sonarsource.com/license/ssal/
*/
// https://sonarsource.github.io/rspec/#/rspec/S5876/javascript
Object.defineProperty(exports, "__esModule", { value: true });
exports.rule = void 0;
const index_js_1 = require("../helpers/index.js");
const meta_js_1 = require("./meta.js");
exports.rule = {
meta: (0, index_js_1.generateMeta)(meta_js_1.meta, {
messages: {
createSession: 'Create a new session during user authentication to prevent session fixation attacks.',
},
}),
create(context) {
let sessionRegenerate = false;
function isSessionRegenerate(node) {
return (node.type === 'CallExpression' &&
node.callee.type === 'MemberExpression' &&
(0, index_js_1.isIdentifier)(node.callee.property, 'regenerate'));
}
function visitCallback(node) {
if (sessionRegenerate) {
// terminate recursion once call is detected
return;
}
if (isSessionRegenerate(node)) {
sessionRegenerate = true;
return;
}
(0, index_js_1.childrenOf)(node, context.sourceCode.visitorKeys).forEach(visitCallback);
}
function hasSessionFalseOption(callExpression) {
const opt = callExpression.arguments[1];
if (opt?.type === 'ObjectExpression') {
const sessionProp = (0, index_js_1.getPropertyWithValue)(context, opt, 'session', false);
return !!sessionProp;
}
return false;
}
return {
CallExpression: (node) => {
const callExpression = node;
if ((0, index_js_1.getFullyQualifiedName)(context, callExpression) === 'passport.authenticate') {
if (hasSessionFalseOption(callExpression)) {
return;
}
const parent = (0, index_js_1.last)(context.sourceCode.getAncestors(node));
if (parent.type === 'CallExpression') {
const callback = (0, index_js_1.getValueOfExpression)(context, parent.arguments[2], 'FunctionExpression');
if (callback && callback.type === 'FunctionExpression') {
sessionRegenerate = false;
visitCallback(callback);
if (!sessionRegenerate) {
context.report({ node: callback, messageId: 'createSession' });
}
}
}
}
},
};
},
};
;