eslint-plugin-sonarjs
Version:
SonarJS rules for ESLint
99 lines (98 loc) • 4.22 kB
JavaScript
;
/*
* SonarQube JavaScript Plugin
* Copyright (C) 2011-2025 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the Sonar Source-Available License Version 1, as published by SonarSource SA.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
* See the Sonar Source-Available License for more details.
*
* You should have received a copy of the Sonar Source-Available License
* along with this program; if not, see https://sonarsource.com/license/ssal/
*/
// https://sonarsource.github.io/rspec/#/rspec/S3514/javascript
Object.defineProperty(exports, "__esModule", { value: true });
exports.rule = void 0;
const index_js_1 = require("../helpers/index.js");
const meta_js_1 = require("./meta.js");
const MAX_INDEX = 4;
const isAllowedIndex = (idx) => idx >= 0 && idx <= MAX_INDEX;
exports.rule = {
meta: (0, index_js_1.generateMeta)(meta_js_1.meta, undefined, true),
create(context) {
function visitStatements(statements) {
const declarationsByObject = new Map();
for (const statement of statements) {
if (statement.type === 'VariableDeclaration') {
visitDeclarations(declarationsByObject, statement.declarations);
}
else {
checkDeclarationsBlock(declarationsByObject);
declarationsByObject.clear();
}
}
checkDeclarationsBlock(declarationsByObject);
}
function visitDeclarations(declarationsByObject, declarations) {
for (const declaration of declarations) {
const id = declaration.id;
if (declaration.init && id.type === 'Identifier') {
const varName = id.name;
const expression = declaration.init;
if (expression.type !== 'MemberExpression') {
continue;
}
const property = expression.property;
if ((0, index_js_1.isIdentifier)(property, varName) ||
((0, index_js_1.isNumberLiteral)(property) && isAllowedIndex(property.value))) {
addDeclaration(declarationsByObject, expression.object, declaration);
}
}
}
}
function addDeclaration(declarationsByObject, object, declaration) {
const key = context.sourceCode.getText(object);
const value = declarationsByObject.get(key);
if (value) {
value.push(declaration);
}
else {
declarationsByObject.set(key, [declaration]);
}
}
function checkDeclarationsBlock(declarationsByObject) {
declarationsByObject.forEach((declarations, key) => {
if (declarations.length > 1) {
const firstKind = getKind(declarations[0]);
const tail = declarations.slice(1);
if (tail.every(decl => getKind(decl) === firstKind)) {
(0, index_js_1.report)(context, {
node: declarations[0],
message: `Use destructuring syntax for these assignments from "${key}".`,
}, tail.map(node => (0, index_js_1.toSecondaryLocation)(node, 'Replace this assignment.')));
}
}
});
}
return {
BlockStatement: (node) => {
visitStatements(node.body);
},
SwitchCase: (node) => {
visitStatements(node.consequent);
},
Program: (node) => {
visitStatements(node.body);
},
};
},
};
function getKind(declarator) {
const declaration = (0, index_js_1.findFirstMatchingAncestor)(declarator, n => n.type === 'VariableDeclaration');
return declaration?.kind;
}