eslint-plugin-sonarjs
Version:
SonarJS rules for ESLint
60 lines (59 loc) • 2.96 kB
JavaScript
;
/*
* SonarQube JavaScript Plugin
* Copyright (C) 2011-2025 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the Sonar Source-Available License Version 1, as published by SonarSource SA.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
* See the Sonar Source-Available License for more details.
*
* You should have received a copy of the Sonar Source-Available License
* along with this program; if not, see https://sonarsource.com/license/ssal/
*/
// https://sonarsource.github.io/rspec/#/rspec/S3403/javascript
Object.defineProperty(exports, "__esModule", { value: true });
exports.rule = void 0;
const index_js_1 = require("../helpers/index.js");
const meta_js_1 = require("./meta.js");
exports.rule = {
meta: (0, index_js_1.generateMeta)(meta_js_1.meta, { hasSuggestions: true }, true),
create(context) {
const services = context.sourceCode.parserServices;
if (!(0, index_js_1.isRequiredParserServices)(services)) {
return {};
}
function isComparableTo(lhs, rhs) {
const checker = services.program.getTypeChecker();
const lhsType = checker.getBaseTypeOfLiteralType((0, index_js_1.getTypeFromTreeNode)(lhs, services));
const rhsType = checker.getBaseTypeOfLiteralType((0, index_js_1.getTypeFromTreeNode)(rhs, services));
// @ts-ignore private API
return (checker.isTypeAssignableTo(lhsType, rhsType) || checker.isTypeAssignableTo(rhsType, lhsType));
}
return {
BinaryExpression: (node) => {
const { left, operator, right } = node;
if (['===', '!=='].includes(operator) && !isComparableTo(left, right)) {
const [actual, expected, outcome] = operator === '===' ? ['===', '==', 'false'] : ['!==', '!=', 'true'];
const operatorToken = context.sourceCode
.getTokensBetween(left, right)
.find(token => token.type === 'Punctuator' && token.value === operator);
(0, index_js_1.report)(context, {
message: `Remove this "${actual}" check; it will always be ${outcome}. Did you mean to use "${expected}"?`,
loc: operatorToken.loc,
suggest: [
{
desc: `Replace "${actual}" with "${expected}"`,
fix: fixer => fixer.replaceText(operatorToken, expected),
},
],
}, [left, right].map(node => (0, index_js_1.toSecondaryLocation)(node)));
}
},
};
},
};