eslint-plugin-sonarjs
Version:
SonarJS rules for ESLint
73 lines (72 loc) • 3.17 kB
JavaScript
;
/*
* SonarQube JavaScript Plugin
* Copyright (C) 2011-2025 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the Sonar Source-Available License Version 1, as published by SonarSource SA.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
* See the Sonar Source-Available License for more details.
*
* You should have received a copy of the Sonar Source-Available License
* along with this program; if not, see https://sonarsource.com/license/ssal/
*/
// https://sonarsource.github.io/rspec/#/rspec/S3003/javascript
Object.defineProperty(exports, "__esModule", { value: true });
exports.rule = void 0;
const index_js_1 = require("../helpers/index.js");
const meta_js_1 = require("./meta.js");
exports.rule = {
meta: (0, index_js_1.generateMeta)(meta_js_1.meta, undefined, true),
create(context) {
const services = context.sourceCode.parserServices;
if (!(0, index_js_1.isRequiredParserServices)(services)) {
return {};
}
return {
BinaryExpression: (node) => {
const { operator, left, right } = node;
if (['<', '<=', '>', '>='].includes(operator) &&
(0, index_js_1.isString)(left, services) &&
(0, index_js_1.isString)(right, services) &&
!isLiteralException(left) &&
!isLiteralException(right) &&
!isWithinSortCallback(context, node)) {
(0, index_js_1.report)(context, {
message: `Convert operands of this use of "${operator}" to number type.`,
loc: context.sourceCode
.getTokensBetween(left, right)
.find(token => token.type === 'Punctuator' && token.value === operator).loc,
}, [left, right].map(node => (0, index_js_1.toSecondaryLocation)(node)));
}
},
};
},
};
function isLiteralException(node) {
return node.type === 'Literal' && node.raw.length === 3;
}
function isWithinSortCallback(context, node) {
const ancestors = context.sourceCode.getAncestors(node).reverse();
const maybeCallback = ancestors.find(node => ['ArrowFunctionExpression', 'FunctionExpression'].includes(node.type));
if (maybeCallback) {
const callback = maybeCallback;
const parent = callback.parent;
if (parent?.type === 'CallExpression') {
const { callee, arguments: args } = parent;
let funcName;
if (callee.type === 'Identifier') {
funcName = callee.name;
}
else if (callee.type === 'MemberExpression' && callee.property.type === 'Identifier') {
funcName = callee.property.name;
}
return funcName?.match(/sort/i) && args.some(arg => arg === callback);
}
}
return false;
}