eslint-plugin-sonarjs
Version:
SonarJS rules for ESLint
68 lines (67 loc) • 2.7 kB
JavaScript
;
/*
* SonarQube JavaScript Plugin
* Copyright (C) 2011-2025 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the Sonar Source-Available License Version 1, as published by SonarSource SA.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
* See the Sonar Source-Available License for more details.
*
* You should have received a copy of the Sonar Source-Available License
* along with this program; if not, see https://sonarsource.com/license/ssal/
*/
// https://sonarsource.github.io/rspec/#/rspec/S2123/javascript
Object.defineProperty(exports, "__esModule", { value: true });
exports.rule = void 0;
const index_js_1 = require("../helpers/index.js");
const meta_js_1 = require("./meta.js");
exports.rule = {
meta: (0, index_js_1.generateMeta)(meta_js_1.meta, {
messages: {
removeIncrement: 'Remove this {{updateOperator}}rement or correct the code not to waste it.',
},
}),
create(context) {
function reportUpdateExpression(updateExpression) {
const updateOperator = updateExpression.operator === '++' ? 'inc' : 'dec';
context.report({
messageId: 'removeIncrement',
data: {
updateOperator,
},
node: updateExpression,
});
}
return {
'ReturnStatement > UpdateExpression'(node) {
const updateExpression = node;
const argument = updateExpression.argument;
if (!updateExpression.prefix &&
argument.type === 'Identifier' &&
isLocalIdentifier(argument, context.sourceCode.getScope(node))) {
reportUpdateExpression(updateExpression);
}
},
AssignmentExpression(node) {
const assignment = node;
const rhs = assignment.right;
if (rhs.type === 'UpdateExpression' && !rhs.prefix) {
const lhs = assignment.left;
if (lhs.type === 'Identifier' &&
rhs.argument.type === 'Identifier' &&
rhs.argument.name === lhs.name) {
reportUpdateExpression(rhs);
}
}
},
};
},
};
function isLocalIdentifier(id, scope) {
return scope.variables.some(v => v.identifiers.some(i => i.name === id.name));
}