eslint-plugin-sonarjs
Version:
SonarJS rules for ESLint
88 lines (87 loc) • 3.16 kB
JavaScript
/*
* SonarQube JavaScript Plugin
* Copyright (C) 2011-2025 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the Sonar Source-Available License Version 1, as published by SonarSource SA.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
* See the Sonar Source-Available License for more details.
*
* You should have received a copy of the Sonar Source-Available License
* along with this program; if not, see https://sonarsource.com/license/ssal/
*/
// https://sonarsource.github.io/rspec/#/rspec/S1764
Object.defineProperty(exports, "__esModule", { value: true });
exports.rule = void 0;
const index_js_1 = require("../helpers/index.js");
const meta_js_1 = require("./meta.js");
const EQUALITY_OPERATOR_TOKEN_KINDS = new Set(['==', '===', '!=', '!==']);
// consider only binary expressions with these operators
const RELEVANT_OPERATOR_TOKEN_KINDS = new Set([
'&&',
'||',
'/',
'-',
'<<',
'>>',
'<',
'<=',
'>',
'>=',
]);
function hasRelevantOperator(node) {
return (RELEVANT_OPERATOR_TOKEN_KINDS.has(node.operator) ||
(EQUALITY_OPERATOR_TOKEN_KINDS.has(node.operator) && !hasIdentifierOperands(node)));
}
function hasIdentifierOperands(node) {
return (0, index_js_1.isIdentifier)(node.left) && (0, index_js_1.isIdentifier)(node.right);
}
function isOneOntoOneShifting(node) {
return (node.operator === '<<' &&
(0, index_js_1.isLiteral)(node.left) &&
(node.left.value === 1 || node.left.value === 1n));
}
const message = 'Correct one of the identical sub-expressions on both sides of operator "{{operator}}"';
exports.rule = {
meta: (0, index_js_1.generateMeta)(meta_js_1.meta, {
messages: {
correctIdenticalSubExpressions: message,
},
}, true),
create(context) {
return {
LogicalExpression(node) {
check(node);
},
BinaryExpression(node) {
check(node);
},
};
function check(expr) {
if (hasRelevantOperator(expr) &&
!isOneOntoOneShifting(expr) &&
(0, index_js_1.areEquivalent)(expr.left, expr.right, context.sourceCode)) {
const secondaryLocations = [];
if (expr.left.loc) {
secondaryLocations.push((0, index_js_1.toSecondaryLocation)(expr.left));
}
(0, index_js_1.report)(context, {
message,
messageId: 'correctIdenticalSubExpressions',
data: {
operator: expr.operator,
},
node: isSonarRuntime() ? expr.right : expr,
}, secondaryLocations);
}
}
function isSonarRuntime() {
return context.options[context.options.length - 1] === 'sonar-runtime';
}
},
};
;