eslint-plugin-sonarjs
Version:
SonarJS rules for ESLint
101 lines (100 loc) • 4.05 kB
JavaScript
/*
* SonarQube JavaScript Plugin
* Copyright (C) 2011-2025 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the Sonar Source-Available License Version 1, as published by SonarSource SA.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
* See the Sonar Source-Available License for more details.
*
* You should have received a copy of the Sonar Source-Available License
* along with this program; if not, see https://sonarsource.com/license/ssal/
*/
// https://sonarsource.github.io/rspec/#/rspec/S1751
Object.defineProperty(exports, "__esModule", { value: true });
exports.rule = void 0;
const index_js_1 = require("../helpers/index.js");
const meta_js_1 = require("./meta.js");
exports.rule = {
meta: (0, index_js_1.generateMeta)(meta_js_1.meta, {
messages: {
refactorLoop: 'Refactor this loop to do more than one iteration.',
},
}),
// @ts-ignore The typings of @typescript-eslint/utils does not contain the 'onX' methods.
create(context) {
const loopingNodes = new Set();
const loops = new Set();
const loopsAndTheirSegments = [];
const codePathSegments = [];
let currentCodePathSegments = [];
return {
ForStatement(node) {
loops.add(node);
},
WhileStatement(node) {
loops.add(node);
},
DoWhileStatement(node) {
loops.add(node);
},
onCodePathStart() {
codePathSegments.push(currentCodePathSegments);
currentCodePathSegments = [];
},
onCodePathSegmentStart(segment) {
currentCodePathSegments.push(segment);
},
onCodePathSegmentEnd() {
currentCodePathSegments.pop();
},
onCodePathEnd() {
currentCodePathSegments = codePathSegments.pop();
},
'WhileStatement > *'(node) {
visitLoopChild(node.parent);
},
'ForStatement > *'(node) {
visitLoopChild(node.parent);
},
onCodePathSegmentLoop(_, toSegment, node) {
if (node.type === 'ContinueStatement') {
loopsAndTheirSegments.forEach(({ segments, loop }) => {
if (segments.includes(toSegment)) {
loopingNodes.add(loop);
}
});
}
else {
loopingNodes.add(node);
}
},
'Program:exit'() {
loops.forEach(loop => {
if (!loopingNodes.has(loop)) {
context.report({
messageId: 'refactorLoop',
loc: context.sourceCode.getFirstToken(loop).loc,
});
}
});
},
};
// Required to correctly process "continue" looping.
// When a loop has a "continue" statement, this "continue" statement triggers a "onCodePathSegmentLoop" event,
// and the corresponding event node is that "continue" statement. Current implementation is based on the fact
// that the "onCodePathSegmentLoop" event is triggered with a loop node. To work this special case around,
// we visit loop children and collect corresponding path segments as these segments are "toSegment"
// in "onCodePathSegmentLoop" event.
function visitLoopChild(parent) {
if (currentCodePathSegments.length > 0) {
loopsAndTheirSegments.push({ segments: [...currentCodePathSegments], loop: parent });
}
}
},
};
;