eslint-plugin-sonarjs
Version:
SonarJS rules for ESLint
66 lines (65 loc) • 2.6 kB
JavaScript
/*
* SonarQube JavaScript Plugin
* Copyright (C) 2011-2025 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the Sonar Source-Available License Version 1, as published by SonarSource SA.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
* See the Sonar Source-Available License for more details.
*
* You should have received a copy of the Sonar Source-Available License
* along with this program; if not, see https://sonarsource.com/license/ssal/
*/
// https://sonarsource.github.io/rspec/#/rspec/S1154/javascript
var __importDefault = (this && this.__importDefault) || function (mod) {
return (mod && mod.__esModule) ? mod : { "default": mod };
};
Object.defineProperty(exports, "__esModule", { value: true });
exports.rule = void 0;
const typescript_1 = __importDefault(require("typescript"));
const index_js_1 = require("../helpers/index.js");
const meta_js_1 = require("./meta.js");
exports.rule = {
meta: (0, index_js_1.generateMeta)(meta_js_1.meta, {
messages: {
uselessStringOp: '{{symbol}} is an immutable object; you must either store or return the result of the operation.',
},
}),
create(context) {
const services = context.sourceCode.parserServices;
if (!(0, index_js_1.isRequiredParserServices)(services)) {
return {};
}
function isString(node) {
const type = (0, index_js_1.getTypeFromTreeNode)(node, services);
return (type.flags & typescript_1.default.TypeFlags.StringLike) !== 0;
}
function getVariable(node) {
let variable = context.sourceCode.getText(node);
if (variable.length > 30) {
variable = 'String';
}
return variable;
}
return {
'ExpressionStatement > CallExpression[callee.type="MemberExpression"]': (node) => {
const { object, property } = node
.callee;
if (isString(object) && property.type === 'Identifier') {
context.report({
messageId: 'uselessStringOp',
data: {
symbol: getVariable(object),
},
node: property,
});
}
},
};
},
};
;