eslint-plugin-sonarjs
Version:
SonarJS rules for ESLint
91 lines (90 loc) • 3.72 kB
JavaScript
;
/*
* SonarQube JavaScript Plugin
* Copyright (C) 2011-2025 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the Sonar Source-Available License Version 1, as published by SonarSource SA.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
* See the Sonar Source-Available License for more details.
*
* You should have received a copy of the Sonar Source-Available License
* along with this program; if not, see https://sonarsource.com/license/ssal/
*/
// https://sonarsource.github.io/rspec/#/rspec/S1121/javascript
Object.defineProperty(exports, "__esModule", { value: true });
exports.rule = void 0;
const index_js_1 = require("../helpers/index.js");
const meta_js_1 = require("./meta.js");
exports.rule = {
meta: (0, index_js_1.generateMeta)(meta_js_1.meta, {
messages: {
extractAssignment: 'Extract the assignment of "{{symbol}}" from this expression.',
},
}),
create(context) {
function isAssignmentStatement(parent) {
return parent.type === 'ExpressionStatement';
}
function isEnclosingChain(parent) {
return parent.type === 'AssignmentExpression';
}
function isEnclosingRelation(parent) {
return (parent.type === 'BinaryExpression' &&
['==', '!=', '===', '!==', '<', '<=', '>', '>='].includes(parent.operator));
}
function isEnclosingSequence(parent) {
return parent.type === 'SequenceExpression';
}
function isEnclosingDeclarator(parent) {
return parent.type === 'VariableDeclarator';
}
function isLambdaBody(parent, expr) {
return parent.type === 'ArrowFunctionExpression' && parent.body === expr;
}
function isConditionalAssignment(parent, expr) {
return parent.type === 'LogicalExpression' && parent.right === expr;
}
function isWhileCondition(parent, expr) {
return ((parent.type === 'DoWhileStatement' || parent.type === 'WhileStatement') &&
parent.test === expr);
}
function isForInitOrUpdate(parent, expr) {
return parent.type === 'ForStatement' && (parent.init === expr || parent.update === expr);
}
return {
AssignmentExpression: (node) => {
const assignment = node;
const parent = (0, index_js_1.getParent)(context, node);
if (parent &&
!isAssignmentStatement(parent) &&
!isEnclosingChain(parent) &&
!isEnclosingRelation(parent) &&
!isEnclosingSequence(parent) &&
!isEnclosingDeclarator(parent) &&
!isLambdaBody(parent, assignment) &&
!isConditionalAssignment(parent, assignment) &&
!isWhileCondition(parent, assignment) &&
!isForInitOrUpdate(parent, assignment)) {
raiseIssue(assignment, context);
}
},
};
},
};
function raiseIssue(node, context) {
const sourceCode = context.sourceCode;
const operator = sourceCode.getFirstTokenBetween(node.left, node.right, token => token.value === node.operator);
const text = sourceCode.getText(node.left);
context.report({
messageId: 'extractAssignment',
data: {
symbol: text,
},
loc: operator.loc,
});
}