eslint-plugin-sonarjs
Version:
SonarJS rules for ESLint
71 lines (70 loc) • 2.84 kB
JavaScript
;
/*
* SonarQube JavaScript Plugin
* Copyright (C) 2011-2024 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
// https://sonarsource.github.io/rspec/#/rspec/S2123/javascript
Object.defineProperty(exports, "__esModule", { value: true });
exports.rule = void 0;
const helpers_1 = require("../helpers");
const meta_1 = require("./meta");
exports.rule = {
meta: (0, helpers_1.generateMeta)(meta_1.meta, {
messages: {
removeIncrement: 'Remove this {{updateOperator}}rement or correct the code not to waste it.',
},
}),
create(context) {
function reportUpdateExpression(updateExpression) {
const updateOperator = updateExpression.operator === '++' ? 'inc' : 'dec';
context.report({
messageId: 'removeIncrement',
data: {
updateOperator,
},
node: updateExpression,
});
}
return {
'ReturnStatement > UpdateExpression'(node) {
const updateExpression = node;
const argument = updateExpression.argument;
if (!updateExpression.prefix &&
argument.type === 'Identifier' &&
isLocalIdentifier(argument, context.sourceCode.getScope(node))) {
reportUpdateExpression(updateExpression);
}
},
AssignmentExpression(node) {
const assignment = node;
const rhs = assignment.right;
if (rhs.type === 'UpdateExpression' && !rhs.prefix) {
const lhs = assignment.left;
if (lhs.type === 'Identifier' &&
rhs.argument.type === 'Identifier' &&
rhs.argument.name === lhs.name) {
reportUpdateExpression(rhs);
}
}
},
};
},
};
function isLocalIdentifier(id, scope) {
return scope.variables.some(v => v.identifiers.some(i => i.name === id.name));
}