eslint-plugin-sonarjs
Version:
SonarJS rules for ESLint
67 lines (66 loc) • 2.53 kB
JavaScript
;
/*
* eslint-plugin-sonarjs
* Copyright (C) 2018-2021 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
// https://sonarsource.github.io/rspec/#/rspec/S1940
var __importDefault = (this && this.__importDefault) || function (mod) {
return (mod && mod.__esModule) ? mod : { "default": mod };
};
const nodes_1 = require("../utils/nodes");
const equivalence_1 = require("../utils/equivalence");
const docs_url_1 = __importDefault(require("../utils/docs-url"));
const rule = {
defaultOptions: [],
meta: {
messages: {
uselessCatch: 'Add logic to this catch clause or eliminate it and rethrow the exception automatically.',
},
schema: [],
type: 'suggestion',
docs: {
description: '"catch" clauses should do more than rethrow',
recommended: 'recommended',
url: (0, docs_url_1.default)(__filename),
},
},
create(context) {
return {
CatchClause: (node) => visitCatchClause(node, context),
};
},
};
function visitCatchClause(catchClause, context) {
const statements = catchClause.body.body;
if (catchClause.param &&
statements.length === 1 &&
onlyRethrows(statements[0], catchClause.param, context.sourceCode)) {
const catchKeyword = context.sourceCode.getFirstToken(catchClause);
context.report({
messageId: 'uselessCatch',
loc: catchKeyword.loc,
});
}
}
function onlyRethrows(statement, catchParam, sourceCode) {
return ((0, nodes_1.isThrowStatement)(statement) &&
catchParam !== null &&
statement.argument !== null &&
(0, equivalence_1.areEquivalent)(catchParam, statement.argument, sourceCode));
}
module.exports = rule;