eslint-plugin-sonarjs
Version:
SonarJS rules for ESLint
75 lines (74 loc) • 3 kB
JavaScript
;
/*
* eslint-plugin-sonarjs
* Copyright (C) 2018-2021 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
// https://sonarsource.github.io/rspec/#/rspec/S1066
var __importDefault = (this && this.__importDefault) || function (mod) {
return (mod && mod.__esModule) ? mod : { "default": mod };
};
const nodes_1 = require("../utils/nodes");
const locations_1 = require("../utils/locations");
const docs_url_1 = __importDefault(require("../utils/docs-url"));
const message = 'Merge this if statement with the nested one.';
const rule = {
defaultOptions: [],
meta: {
messages: {
mergeNestedIfStatement: message,
sonarRuntime: '{{sonarRuntimeData}}',
},
type: 'suggestion',
docs: {
description: 'Collapsible "if" statements should be merged',
recommended: 'recommended',
url: (0, docs_url_1.default)(__filename),
},
schema: [
{
// internal parameter
type: 'string',
enum: ['sonar-runtime'],
},
],
},
create(context) {
return {
IfStatement(node) {
let { consequent } = node;
if ((0, nodes_1.isBlockStatement)(consequent) && consequent.body.length === 1) {
consequent = consequent.body[0];
}
if (isIfStatementWithoutElse(node) && isIfStatementWithoutElse(consequent)) {
const ifKeyword = context.sourceCode.getFirstToken(consequent);
const enclosingIfKeyword = context.sourceCode.getFirstToken(node);
if (ifKeyword && enclosingIfKeyword) {
(0, locations_1.report)(context, {
messageId: 'mergeNestedIfStatement',
loc: enclosingIfKeyword.loc,
}, [(0, locations_1.issueLocation)(ifKeyword.loc, ifKeyword.loc, 'Nested "if" statement.')], message);
}
}
},
};
function isIfStatementWithoutElse(node) {
return (0, nodes_1.isIfStatement)(node) && !node.alternate;
}
},
};
module.exports = rule;