eslint-plugin-sonarjs
Version:
SonarJS rules for ESLint
68 lines • 3.02 kB
JavaScript
;
/*
* eslint-plugin-sonarjs
* Copyright (C) 2018 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
// https://jira.sonarsource.com/browse/RSPEC-3923
const nodes_1 = require("../utils/nodes");
const equivalence_1 = require("../utils/equivalence");
const conditions_1 = require("../utils/conditions");
const MESSAGE = "Remove this conditional structure or edit its code blocks so that they're not all the same.";
const MESSAGE_CONDITIONAL_EXPRESSION = 'This conditional operation returns the same value whether the condition is "true" or "false".';
const rule = {
meta: {
type: "problem",
},
create(context) {
return {
IfStatement(node) {
const ifStmt = node;
// don't visit `else if` statements
const parent = nodes_1.getParent(context);
if (!nodes_1.isIfStatement(parent)) {
const { branches, endsWithElse } = conditions_1.collectIfBranches(ifStmt);
if (endsWithElse && allDuplicated(branches)) {
context.report({ message: MESSAGE, node: ifStmt });
}
}
},
SwitchStatement(node) {
const switchStmt = node;
const { branches, endsWithDefault } = conditions_1.collectSwitchBranches(switchStmt);
if (endsWithDefault && allDuplicated(branches)) {
context.report({ message: MESSAGE, node: switchStmt });
}
},
ConditionalExpression(node) {
const conditional = node;
const branches = [conditional.consequent, conditional.alternate];
if (allDuplicated(branches)) {
context.report({ message: MESSAGE_CONDITIONAL_EXPRESSION, node: conditional });
}
},
};
function allDuplicated(branches) {
return (branches.length > 1 &&
branches.slice(1).every((branch, index) => {
return equivalence_1.areEquivalent(branch, branches[index], context.getSourceCode());
}));
}
},
};
module.exports = rule;
//# sourceMappingURL=no-all-duplicated-branches.js.map