eslint-plugin-ember
Version:
ESLint plugin for Ember.js apps
68 lines (58 loc) • 1.69 kB
JavaScript
;
function isDirectlyInClass(node) {
let currentNode = node.parent;
let inFunctionAlready = false;
while (currentNode) {
if (currentNode.type === 'MethodDefinition') {
return true;
} else if (currentNode.type === 'FunctionExpression') {
if (inFunctionAlready) {
return false;
} else {
inFunctionAlready = true;
}
}
currentNode = currentNode.parent;
}
return false;
}
/** @type {import('eslint').Rule.RuleModule} */
module.exports = {
meta: {
type: 'problem',
docs: {
description: 'disallow use of `this._super` in ES class methods',
category: 'Ember Octane',
recommended: true,
url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/no-ember-super-in-es-classes.md',
},
fixable: 'code',
schema: [],
},
create(context) {
return {
'MethodDefinition MemberExpression[object.type="ThisExpression"][property.name="_super"]'(
node
) {
if (!isDirectlyInClass(node)) {
return;
}
context.report({
node,
message: "Don't use `this._super` in ES classes; instead, you should use `super`",
fix(fixer) {
let method = node;
while (method.type !== 'MethodDefinition') {
method = method.parent;
}
if (method.key.type === 'Identifier') {
return fixer.replaceText(node, `super.${method.key.name}`);
}
const text = context.sourceCode.getText(method.key);
return fixer.replaceText(node, `super[${text}]`);
},
});
},
};
},
};