canonical
Version:
Canonical code style linter and formatter for JavaScript, SCSS and CSS.
28 lines (23 loc) • 1.03 kB
JavaScript
/**
* @fileoverview Rule to check if a call to _.forEach should be a call to _.filter
*/
;
//------------------------------------------------------------------------------
// Rule Definition
//------------------------------------------------------------------------------
module.exports = function (context) {
var lodashUtil = require('../util/lodashUtil');
var astUtil = require('../util/astUtil');
function onlyHasPush(func) {
var firstLine = astUtil.getFirstFunctionLine(func);
var exp = func && func.type === 'ArrowFunctionExpression' ? firstLine : firstLine && firstLine.expression;
return astUtil.hasOnlyOneStatement(func) && astUtil.getMethodName(exp) === 'push';
}
return {
CallExpression: function (node) {
if (lodashUtil.isCallToMethod(node, 'forEach') && onlyHasPush(lodashUtil.getLodashIteratee(node))) {
context.report(node, 'Prefer _.map over a _.forEach with a push to an array inside');
}
}
};
};