canonical
Version:
Canonical code style linter and formatter for JavaScript, SCSS and CSS.
32 lines (26 loc) • 1.25 kB
JavaScript
/**
* @fileoverview Rule to check if a call to filter should be a call to reject
*/
;
//------------------------------------------------------------------------------
// Rule Definition
//------------------------------------------------------------------------------
module.exports = function (context) {
var lodashUtil = require('../util/lodashUtil');
var astUtil = require('../util/astUtil');
var DEFAULT_MAX_PROPERTY_PATH_LENGTH = 3;
var maxPropertyPathLength = parseInt(context.options[0], 10) || DEFAULT_MAX_PROPERTY_PATH_LENGTH;
function isNegativeExpressionFunction(func) {
var returnValue = astUtil.getValueReturnedInFirstLine(func);
var firstParamName = astUtil.getFirstParamName(func);
return astUtil.isNegationOfParamMember(returnValue, firstParamName, maxPropertyPathLength) ||
astUtil.isNotEqEqToParamMember(returnValue, firstParamName, maxPropertyPathLength);
}
return {
CallExpression: function (node) {
if (lodashUtil.isCallToMethod(node, 'filter') && isNegativeExpressionFunction(lodashUtil.getLodashIteratee(node))) {
context.report(node, 'Prefer _.reject over negative condition');
}
}
};
};