@longnc/themartec-smtpapi
Version:
Build SendGrid X-SMTPAPI headers in nodejs. And this version for upgrade some packages to latest and fix security
155 lines (102 loc) • 4.84 kB
Markdown
Hello! Thank you for choosing to help contribute to one of the SendGrid open source libraries. There are many ways you can contribute and help is always welcome. We simply ask that you follow the following contribution policies.
- [Improvements to the Codebase](#improvements-to-the-codebase)
- [Understanding the Code Base](#understanding-the-codebase)
- [Testing](#testing)
- [Style Guidelines & Naming Conventions](#style_guidelines_and_naming_conventions)
- [Creating a Pull Request](#creating_a_pull_request)
- [Code Reviews](#code-reviews)
<a name="improvements-to-the-codebase"></a>
## Improvements to the Codebase
We welcome direct contributions to the smtpapi-nodejs code base. Thank you!
### Development Environment
#### Install and Run Locally
##### Prerequisites
- Node.js version 0.10, 0.12 or 4
- The SendGrid Service, starting at the [free level](https://sendgrid.com/free?source=smtpapi-nodejs)
- Please see [package.json](package.json)
##### Initial setup:
```bash
git clone https://github.com/sendgrid/smtpapi-nodejs.git
cd smtpapi-nodejs
npm install
```
### Environment Variables
First, get your free SendGrid account [here](https://sendgrid.com/free?source=smtpapi-nodejs).
Next, update your environment with your [SENDGRID_API_KEY](https://app.sendgrid.com/settings/api_keys).
```bash
echo "export SENDGRID_USERNAME='YOUR_USERNAME'" > sendgrid.env
echo "export SENDGRID_PASSWORD='YOUR_PASSWORD'" >> sendgrid.env
echo "sendgrid.env" >> .gitignore
source ./sendgrid.env
```
##### Execute:
See the [examples folder](examples) to get started quickly.
To run the example (after updating the settings and the emails):
```bash
node examples/example.js
```
<a name="understanding-the-codebase"></a>
## Understanding the Code Base
**/examples**
Working examples that demonstrate usage.
**/test**
Unit tests.
**/lib**
Source code.
<a name="testing"></a>
## Testing
All PRs require passing tests before the PR will be reviewed.
All test files are in the [`test`](test) directory.
For the purposes of contributing to this repo, please update the [`main.js`](test/main.js) file with unit tests as you modify the code.
To run the tests:
```bash
npm test
```
<a name="style-guidelines-and-naming-conventions"></a>
## Style Guidelines & Naming Conventions
Generally, we follow the style guidelines as suggested by the official language. However, we ask that you conform to the styles that already exist in the library. If you wish to deviate, please explain your reasoning.
- [Unofficial Style Guide](https://github.com/felixge/node-style-guide)
Please run your code through:
- [ESLint](http://eslint.org/) with the standard style guide.
- [esdoc](USAGE.md) to check the documentation coverage of your added code.
## Creating a Pull Request<a name="creating-a-pull-request"></a>
1. [Fork](https://help.github.com/fork-a-repo/) the project, clone your fork,
and configure the remotes:
```bash
# Clone your fork of the repo into the current directory
git clone https://github.com/sendgrid/smtpapi-nodejs
# Navigate to the newly cloned directory
cd smtpapi-nodejs
# Assign the original repo to a remote called "upstream"
git remote add upstream https://github.com/sendgrid/smtpapi-nodejs
```
2. If you cloned a while ago, get the latest changes from upstream:
```bash
git checkout <dev-branch>
git pull upstream <dev-branch>
```
3. Create a new topic branch (off the main project development branch) to
contain your feature, change, or fix:
```bash
git checkout -b <topic-branch-name>
```
4. Commit your changes in logical chunks. Please adhere to these [git commit
message guidelines](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
or your code is unlikely to be merged into the main project. Use Git's
[interactive rebase](https://help.github.com/articles/interactive-rebase)
feature to tidy up your commits before making them public.
4a. Create tests.
4b. Create or update the example code that demonstrates the functionality of this change to the code.
5. Locally merge (or rebase) the upstream development branch into your topic branch:
```bash
git pull [--rebase] upstream main
```
6. Push your topic branch up to your fork:
```bash
git push origin <topic-branch-name>
```
7. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/)
with a clear title and description against the `main` branch. All tests must be passing before we will review the PR.
<a name="code-reviews"></a>
## Code Reviews
If you can, please look at open PRs and review them. Give feedback and help us merge these PRs much faster! If you don't know how, Github has some great [information on how to review a Pull Request](https://help.github.com/articles/about-pull-request-reviews).