@kevinoid/eslint-config/rules/best-practices.js

ESLint shareable config for @kevinoid's style (based on airbnb).

// ESLint common configuration rules for best practices
// https://eslint.org/docs/rules/#best-practices

"use strict";

const airbnbBestPractices =
  require("eslint-config-airbnb-base/rules/best-practices");

module.exports = {
  "rules": {
    // require curly braces around all control statements, not just multi-line.
    "curly": ["error", "all"],

    // disallow empty static blocks
    // TODO [eslint@>=9]: Remove.  Included in default config.
    "no-empty-static-block": "error",

    // disallow unnecessary parentheses
    // allow unnecessary parentheses where useful for disambiguation
    "no-extra-parens": ["error", "all", {
      "conditionalAssign": false,
      "enforceForArrowConditionals": false,
      "nestedBinaryExpressions": false,
      "returnAssign": false
    }],

    // allow creation of functions within loops
    // This is only a problem with var, which is disallowed by the no-var rule.
    // The unicorn/consistent-function-scoping rule catches unnecessary depth.
    //
    // Note: IE 11 supports const/let block scoping, but loop index is outside
    // block scope, so a copy must be made to capture it.
    "no-loop-func": "off",

    // disallow multiple spaces, except before EOL comments
    // (which can be useful for inline comment alignment)
    "no-multi-spaces": ["error", { "ignoreEOLComments": true }],

    // disallow calls to the Object constructor without an argument
    // TODO [eslint-config-airbnb-base@>=16]: Remove if enabled
    "no-object-constructor": "error",

    // allow reassignment of function parameters
    // simplicity for optional arguments outweighs the perf advantage, usually
    "no-param-reassign": "off",

    // disallow certain object properties
    "no-restricted-properties":
      airbnbBestPractices
        .rules["no-restricted-properties"]
        // remove arguments.callee restriction, which is covered by the
        // built-in no-caller rule, which is easier to disable as needed.
        .filter((restriction) => typeof restriction !== "object"
          || restriction.object !== "arguments"
          || restriction.property !== "callee"),

    // disallow unnecessary use of Function.prototype.{apply,call}
    "no-useless-call": "error",

    // Prefer Object.hasOwn() over Object.prototype.hasOwnProperty.call()
    "prefer-object-has-own": "error",

    // require using Error objects as Promise rejection reason (including empty)
    "prefer-promise-reject-errors": ["error", { "allowEmptyReject": false }],

    // don't require all vars to be at top of their containing scope
    // benefits from locality (comprehensibility, ease of editing) outweigh
    // matching effective scope, since ESLint will warn about use-before-decl.
    "vars-on-top": "off"
  }
};