@bitkyc08/opencodex
Version:
Universal provider proxy for OpenAI Codex & Claude Code — use any LLM with Codex CLI/App/SDK and Claude Code
1,537 lines • 69.4 kB
text/typescript
/**
* prompt-layers.ts — the Codex prompt-layer surface in `$CODEX_HOME/config.toml`.
*
* Scope boundary: this module owns the five `include_*` prompt toggles and the
* generated `developer_instructions` projection. It is a SIBLING of
* `features.ts`, not an extension of it: that module's header explicitly forbids
* broadening itself past `multi_agent_v2`, so the technique is copied here
* rather than the file being widened.
*
* Two design decisions are load-bearing and were forced by an adversarial audit
* (devlog/_plan/260802_codex_set_prompt_composer/):
*
* 1. NO USER PROSE IS PARSED BACK OUT OF TOML. Custom layers live in
* `opencodex-prompt.json`, which we own outright; config.toml receives a
* write-only projection of the enabled subset. Layer identity never has to
* survive a round trip through a TOML parser.
*
* 2. NO TOML LIBRARY IS USED TO VERIFY WHAT WE WROTE. Measured on Bun 1.3.14,
* `Bun.TOML.parse` transposes `\t` and `\f`, rejects `\u0007`, and does not
* trim the newline after an opening `'''`. Codex parses with Rust
* `toml_edit`, so verifying through a JS parser could report success on a
* file Codex reads differently. Instead the accepted character set is
* restricted until escaping is total under three rules, and verification is
* a byte comparison.
*
* CODEX_HOME is resolved at CALL time (the `features.ts:58-67` pattern) so tests
* can point fixtures via env or an explicit path.
*/
import { existsSync, readdirSync, realpathSync } from "node:fs";
import { dirname, join, resolve } from "node:path";
import { createHash, randomBytes } from "node:crypto";
import { expandUserPath } from "../config";
import { resolveCodexHomeDir } from "./home";
import { prepareCodexHome } from "./prepared-home";
import {
durableWrite,
durableWriteExclusive,
durableDelete,
encodeJournal,
ensureDir,
hashBytes,
recoverIfNeeded as recoverJournal,
type JournalRecord,
expectingImage,
} from "./prompt-journal";
import { readBaseImportSource } from "./prompt-layers/import-source";
import { release, stillHeld, tryAcquire } from "./prompt-lock";
import { configWriteLockFailureMessage, withConfigWriteLockHeld, publishConfigWrite, publishConfigWriteTarget, watchConfigWriteTargets, type LockHandle } from "./config-write-lock";
// ---------------------------------------------------------------------------
// Inventory — ONE definition, consumed by the route and the GUI alike.
// Classes are the five in devlog 001 §4; the partition is total and disjoint.
// ---------------------------------------------------------------------------
export type LayerClass =
| "base"
| "config-toggle"
| "feature-gated"
| "runtime-conditional"
| "extension-unknown";
export type ToggleId =
| "permissions"
| "collaboration"
| "environment"
| "apps"
| "skills";
export interface LayerDescriptor {
id: string;
class: LayerClass;
/** config key for config-toggle and feature-gated rows; null otherwise */
key: string | null;
/** documented default when the key is absent */
default: boolean | null;
/** assembly index from devlog 001 §1; null when registration-order dependent */
order: number | null;
}
/**
* Assembly order per `core/src/session/world_state.rs`. `base-instructions` is
* NOT a world-state section — it travels in the Responses `instructions` field
* — so it carries order 0 and sits ahead of the rest.
*
* `plugins` is `runtime-conditional`, not feature-gated: `core/src/mcp.rs:200`
* computes `selected_plugin_available || !capability_summaries().is_empty()`,
* so `[features] plugins` influences the right operand but does not gate
* emission.
*/
export const LAYER_INVENTORY: readonly LayerDescriptor[] = Object.freeze([
{ id: "base-instructions", class: "base", key: null, default: null, order: 0 },
{ id: "model-switch", class: "runtime-conditional", key: null, default: null, order: 1 },
{ id: "personality", class: "feature-gated", key: "features.personality", default: true, order: 2 },
{ id: "context-window-guidance", class: "feature-gated", key: "features.token_budget", default: false, order: 3 },
{ id: "realtime", class: "runtime-conditional", key: null, default: null, order: 4 },
{ id: "agents-md", class: "runtime-conditional", key: null, default: null, order: 5 },
{ id: "permissions", class: "config-toggle", key: "include_permissions_instructions", default: true, order: 6 },
{ id: "collaboration", class: "config-toggle", key: "include_collaboration_mode_instructions", default: true, order: 7 },
{ id: "environment", class: "config-toggle", key: "include_environment_context", default: true, order: 8 },
{ id: "environments-instructions", class: "feature-gated", key: "features.deferred_executor", default: false, order: 9 },
{ id: "apps", class: "config-toggle", key: "include_apps_instructions", default: true, order: 10 },
{ id: "plugins", class: "runtime-conditional", key: null, default: null, order: 11 },
{ id: "tools", class: "feature-gated", key: "features.deferred_tool_world_state", default: false, order: 12 },
{ id: "skills", class: "config-toggle", key: "skills.include_instructions", default: true, order: 13 },
{ id: "multi-agent-mode", class: "feature-gated", key: "features.multi_agent_v2.enabled", default: false, order: 14 },
/**
* Commit and pull-request attribution, contributed by `ext/git-attribution` rather
* than by a world_state.rs section — which is why it is absent from the order list
* above and carries `order: null`: it registers through
* `extensions.context_contributors()` (`core/src/session/world_state.rs:64-66`),
* whose position is registration-order dependent.
*
* `runtime-conditional`, NOT feature-gated. `ext/git-attribution/src/lib.rs:33-80`
* resolves enablement from the AUTH SERVER via `resolve_attribution_policy`, caches
* it on the thread store, and falls back to disabled when the lookup fails.
* `features/src/lib.rs:277` records the old config flag as removed, so there is no
* key for this GUI to write and nothing in [features] to point a user at.
*
* Both states emit text: enabled sends the `Co-authored-by: Codex` trailer plus the
* `Generated with Codex.` PR marker, disabled sends an explicit countermand. So the
* row's condition line must name the policy rather than claiming "always on".
*/
{ id: "git-attribution", class: "runtime-conditional", key: null, default: null, order: null },
] as const);
/**
* The write allowlist. Fixed, never computed: `config_toml.rs` does NOT carry
* serde's `deny_unknown_fields`, so a typo'd key is silently ignored in normal
* mode and a hard startup error under `--strict-config`. A fixed table means
* the GUI can never emit a key it did not intend.
*/
const TOGGLE_KEYS: Record<ToggleId, { table: string | null; key: string }> = {
permissions: { table: null, key: "include_permissions_instructions" },
collaboration: { table: null, key: "include_collaboration_mode_instructions" },
environment: { table: null, key: "include_environment_context" },
apps: { table: null, key: "include_apps_instructions" },
skills: { table: "skills", key: "include_instructions" },
};
export const TOGGLE_IDS = Object.freeze(Object.keys(TOGGLE_KEYS) as ToggleId[]);
export function isToggleId(value: string): value is ToggleId {
return Object.prototype.hasOwnProperty.call(TOGGLE_KEYS, value);
}
export { activeConfigPath, activeStorePath, activeBaseVariantDir } from "./prompt-layers/paths";
export type { Paths } from "./prompt-layers/paths";
export { computeRevision, readFileBytes } from "./prompt-layers/revision";
export { normalizeBody, findInvalidCharacter, encodeBasicString, decodeBasicString } from "./prompt-layers/encoding";
export type { CharacterFinding } from "./prompt-layers/encoding";
export { inspectOwnership } from "./prompt-layers/toml-read";
export type { Ownership } from "./prompt-layers/toml-read";
import { activeConfigPath, activeStorePath, activeBaseVariantDir, journalPathFor, lockPathFor, type Paths } from "./prompt-layers/paths";
import { readFileOrNull, computeRevision, updateFingerprintField } from "./prompt-layers/revision";
import { normalizeBody, findInvalidCharacter, decodeBasicString, decodeTomlBasicString } from "./prompt-layers/encoding";
import { rootArrayEntries, hasRootKey, rootLines, rootValue, scopedBool, scopedRootLines, inspectOwnership } from "./prompt-layers/toml-read";
import {
setRootBool, setRootString, setTableBool, setProjection, removeUnownedProjection,
rootKeyValueForm, UnsupportedTomlForm,
} from "./prompt-layers/toml-edit";
/**
* Instruction documents the prompt probe renders out of CODEX_HOME, in the
* precedence order Codex itself applies: an `AGENTS.override.md` shadows
* `AGENTS.md`. Both are hashed into the probe fingerprint, because either one
* changes the rendered project document without touching a managed file.
*/
const PROBE_INSTRUCTION_FILES = ["AGENTS.override.md", "AGENTS.md"] as const;
/**
* The project-document filenames Codex would look for in a given home, in its own
* order: the two built-ins first, then whatever `project_doc_fallback_filenames`
* adds, de-duplicated (`core/src/agents_md.rs` `candidate_filenames`).
*
* Read from config rather than hard-coded, because a user who configures
* `TEAM.md` renders TEAM.md, and a fingerprint that only knew about AGENTS.md
* would let an edit to it pass unnoticed.
*
*/
function probeInstructionFilenames(configBytes: string | null): string[] {
const names: string[] = [...PROBE_INSTRUCTION_FILES];
for (const entry of rootArrayEntries(configBytes, "project_doc_fallback_filenames")) {
// Upstream trims each configured name and drops whitespace-only entries
// (`core/src/config/mod.rs`), so " TEAM.md " and "TEAM.md" are one filename.
const name = entry.trim();
if (name === "") continue;
if (!names.includes(name)) names.push(name);
}
return names;
}
/**
* The directories Codex would look in for a project document, given the home the
* probe runs in.
*
* Upstream finds the nearest ancestor holding a `project_root_markers` entry
* (default `.git`) and then searches every directory from that root down to the cwd,
* inclusive; with no such ancestor it searches the cwd alone
* (`core/src/agents_md.rs` `agents_md_paths`).
*
* This was originally written off as unreachable on the grounds that the probe runs
* in CODEX_HOME with no checkout around it. That was wrong, and a review round caught
* it: `~/.codex` inside a dotfiles repository is an ordinary setup, and there the
* walk finds real documents. The walk is cheap — a bounded number of `existsSync`
* calls beside a subprocess spawn — so it is performed rather than assumed away.
*/
function probeProjectDocDirs(home: string, configBytes: string | null): string[] {
const markers = projectRootMarkers(configBytes);
// An explicitly empty array disables root detection upstream, which is not the same
// as an absent key falling back to the default.
if (markers.length === 0) return [home];
let root: string | null = null;
for (let dir = home; ; ) {
if (markers.some(marker => existsSync(join(dir, marker)))) { root = dir; break; }
const parent = dirname(dir);
if (parent === dir) break;
dir = parent;
}
if (root === null) return [home];
const dirs: string[] = [];
for (let dir = home; ; ) {
dirs.push(dir);
if (dir === root) break;
const parent = dirname(dir);
if (parent === dir) break;
dir = parent;
}
// Root first, matching upstream's reversed search order. Order is load-bearing:
// the digest must not change merely because the walk was traversed the other way.
return dirs.reverse();
}
/** `project_root_markers`, defaulting to `.git` when the key is absent. */
function projectRootMarkers(configBytes: string | null): string[] {
if (!hasRootKey(configBytes, "project_root_markers")) return [".git"];
// Present-but-empty disables root detection upstream, which is why presence is
// tested separately from the decoded entries rather than inferred from them.
return rootArrayEntries(configBytes, "project_root_markers").filter(m => m !== "");
}
// ---------------------------------------------------------------------------
// Store — the single source of truth for custom layers.
// ---------------------------------------------------------------------------
export interface CustomLayer {
/** [a-z0-9]{6}, stable across edits */
id: string;
title: string;
body: string;
enabled: boolean;
}
const LAYER_ID = /^[a-z0-9]{6}$/;
function isCustomLayer(value: unknown): value is CustomLayer {
if (!value || typeof value !== "object") return false;
const v = value as Record<string, unknown>;
return typeof v.id === "string" && LAYER_ID.test(v.id)
&& typeof v.title === "string"
&& typeof v.body === "string"
&& typeof v.enabled === "boolean";
}
/** null means unreadable/malformed, which is NOT the same as an empty store. */
export function parseStore(storeBytes: string | null): CustomLayer[] | null {
if (storeBytes === null) return null;
let parsed: unknown;
try {
parsed = JSON.parse(storeBytes);
} catch {
return null;
}
if (!parsed || typeof parsed !== "object") return null;
const layers = (parsed as { layers?: unknown }).layers;
if (!Array.isArray(layers) || !layers.every(isCustomLayer)) return null;
const ids = new Set(layers.map(l => l.id));
if (ids.size !== layers.length) return null;
return layers;
}
/** Enabled layers, joined in order. This is the value written to config.toml. */
export function composeProjection(layers: readonly CustomLayer[]): string {
return layers.filter(l => l.enabled).map(l => l.body).join("\n\n");
}
// ---------------------------------------------------------------------------
// Snapshot
// ---------------------------------------------------------------------------
export interface ToggleState {
id: ToggleId;
key: string;
/** null = the key is absent from the user file */
userFileValue: boolean | null;
/**
* userFileValue ?? default. NOT the resolved Codex value: opencodex reads one
* of the eight config layers, so it reports this file's value under a name
* that says as much.
*/
defaultedUserValue: boolean;
default: boolean;
}
export type Drift =
| "journal-present"
| "projection-stale"
| "store-missing"
| "owned-malformed"
| null;
/** One authored base-prompt variant. `default` is never represented here. */
export interface BaseVariant {
id: string;
title: string;
body: string;
bytes: number;
}
/**
* Which base prompt is in force. THREE values, not two.
*
* - `default` — `model_instructions_file` is absent, so Codex uses its own base prompt.
* This is the absence of a key, not a body we store: there is nothing to edit and
* nothing to delete, which is what makes the default structurally immutable rather
* than merely guarded.
* - a variant id — the key points inside our own variant directory.
* - `external` — the key is set and points somewhere else.
*
* The third value is load-bearing and an audit forced it. Collapsing it into `default`
* would have shown a user "Codex's own base prompt" while their base prompt was in fact
* replaced by a file they had set by hand. The panel already ships a notice for that
* state in ten locales; this keeps reporting it instead of overwriting a key we do not
* own.
*/
export type BaseSelection = { kind: "default" } | { kind: "variant"; id: string } | { kind: "external"; path: string };
export interface PromptLayerSnapshot {
configPath: string;
storePath: string;
configExists: boolean;
readable: boolean;
developerInstructionsOwned: boolean;
/** non-null blocks mutations until resolved */
drift: Drift;
toggles: ToggleState[];
custom: CustomLayer[];
modelInstructionsFile: string | null;
baseVariants: BaseVariant[];
baseSelection: BaseSelection;
revision: string;
}
function readToggle(configBytes: string | null, id: ToggleId): ToggleState {
const spec = TOGGLE_KEYS[id];
const descriptor = LAYER_INVENTORY.find(d => d.id === id)!;
const fallback = descriptor.default ?? true;
const key = spec.table ? `${spec.table}.${spec.key}` : spec.key;
let value: boolean | null = null;
if (configBytes !== null) {
value = scopedBool(configBytes, spec.table ?? null, spec.key);
}
return {
id,
key,
userFileValue: value,
defaultedUserValue: value ?? fallback,
default: fallback,
};
}
function readModelInstructionsFile(configBytes: string | null): string | null {
if (configBytes === null) return null;
const parsed = rootValue(configBytes, "model_instructions_file");
if (typeof parsed === "string") return parsed;
if (parsed === undefined) return null;
for (const line of scopedRootLines(configBytes)) {
// Capture the whole literal INCLUDING its quotes and decode it, rather than
// returning the raw inner text. `setRootString` writes this key through
// `encodeBasicString`, which escapes backslashes, so on Windows the stored
// literal is "C:\\Users\\..." while the path is "C:\Users\...".
//
// Bun may reject an unrelated safe-for-Codex integer. Decode the standard
// TOML escapes here, and never mistake an undecodable literal for a path.
const m = /^\s*model_instructions_file\s*=\s*("(?:[^"\\]|\\.)*")\s*(?:#.*)?$/.exec(line.replace(/\r$/, ""));
if (m) return decodeTomlBasicString(m[1]!) ?? "<unreadable model_instructions_file>";
}
// A present non-string value or unrecognised spelling fails closed. Only
// `undefined` above proves that the setting is absent.
return "<unreadable model_instructions_file>";
}
/** Variant ids are ours to generate, so they stay in one narrow shape. */
const BASE_VARIANT_ID = /^[a-z0-9]{6}$/;
/**
* The variant files on disk, newest-id-last so the picker order is stable.
*
* `default.md` is SKIPPED rather than read: `default` names the absence of a key, so a
* file claiming that id would appear as a fourth variant whose selection could never be
* expressed. Anything not matching our own id shape is skipped for the same reason - we
* only report what we could also write.
*/
export function readBaseVariants(opts?: Paths): BaseVariant[] {
const dir = activeBaseVariantDir(opts);
let names: string[];
try {
names = readdirSync(dir);
} catch {
// Absent directory is an ordinary first run, not an error.
return [];
}
const out: BaseVariant[] = [];
for (const name of names.sort()) {
if (!name.endsWith(".md")) continue;
const id = name.slice(0, -3);
if (!BASE_VARIANT_ID.test(id)) continue;
const body = readFileOrNull(join(dir, name));
if (body === null) continue;
// First line is the title when it is a markdown heading; the rest is the prompt.
// Storing the title inside the file keeps one artifact per variant instead of a
// sidecar index that can disagree with it.
const nl = body.indexOf("\n");
const firstLine = nl === -1 ? body : body.slice(0, nl);
const titled = firstLine.startsWith("# ");
out.push({
id,
title: titled ? firstLine.slice(2).trim() : id,
body: titled ? body.slice(nl === -1 ? body.length : nl + 1) : body,
bytes: Buffer.byteLength(body, "utf8"),
});
}
return out;
}
/**
* Resolve which base prompt is in force, given the config bytes and the variants.
*
* Comparison is by RESOLVED path: `~/.codex/opencodex-prompt-base/abc123.md` and an
* absolute spelling of the same file are the same selection, and treating them as
* different would report `external` for a variant we wrote ourselves.
*/
export function resolveBaseSelection(
configBytes: string | null,
variants: readonly BaseVariant[],
opts?: Paths,
): BaseSelection {
const raw = readModelInstructionsFile(configBytes);
if (raw === null) return { kind: "default" };
const dir = activeBaseVariantDir(opts);
let resolved: string;
try {
resolved = resolve(dirname(activeConfigPath(opts)), expandUserPath(raw));
} catch {
return { kind: "external", path: raw };
}
for (const variant of variants) {
if (resolved === resolve(join(dir, `${variant.id}.md`))) {
return { kind: "variant", id: variant.id };
}
}
return { kind: "external", path: raw };
}
/**
* Pure. Never writes, never locks, never recovers — a GET must not modify a
* user's configuration, so drift is REPORTED here and resolved elsewhere.
*/
export function readPromptLayers(opts?: Paths): PromptLayerSnapshot {
const configPath = activeConfigPath(opts);
const storePath = activeStorePath(opts);
const configExists = existsSync(configPath);
const configBytes = readFileOrNull(configPath);
const storeExists = existsSync(storePath);
const storeBytes = readFileOrNull(storePath);
// Present but unreadable is a hard stop; absent is an ordinary first run.
const readable = !configExists || configBytes !== null;
const ownership = inspectOwnership(configBytes);
const layers = parseStore(storeBytes);
const projection = ownership.state === "owned"
? decodeBasicString(ownership.literal)
: null;
const baseVariants = readBaseVariants(opts);
let drift: Drift = null;
if (existsSync(`${storePath.replace(/\.json$/, "")}.journal`)) {
drift = "journal-present";
} else if (ownership.state === "owned-malformed") {
drift = "owned-malformed";
} else if (!storeExists && projection !== null && projection.length > 0) {
// The store is gone while a live projection remains. Treating this as an
// empty store would erase the active prompt on the next write.
drift = "store-missing";
} else if (layers !== null && projection !== null && composeProjection(layers) !== projection) {
drift = "projection-stale";
}
return {
configPath,
storePath,
configExists,
readable,
developerInstructionsOwned: ownership.state === "owned",
drift,
toggles: TOGGLE_IDS.map(id => readToggle(configBytes, id)),
custom: layers ?? [],
modelInstructionsFile: readModelInstructionsFile(configBytes),
baseVariants,
baseSelection: resolveBaseSelection(configBytes, baseVariants, opts),
revision: computeRevision(configBytes, storeBytes),
};
}
/**
* Identity for prompt-text probe admission, deliberately separate from the
* optimistic-concurrency revision above. The revision covers only config/store
* transaction bytes; an edit to the selected base variant changes the prompt
* without changing that transaction contract.
*
* The instruction documents in CODEX_HOME are hashed for the same reason, and they
* are read from `resolveCodexHomeDir()` rather than from `activeConfigPath`'s
* directory. Those two are deliberately different under test — the route fixtures
* inject `codexPromptPaths` at a temp root while CODEX_HOME points at a decoy — and
* the probe renders whatever lives in the home it actually runs in. Deriving the
* path from the injected config would name a file the probe never reads, which is
* a fingerprint that cannot fail rather than evidence.
*
* A BOUNDED invalidation key, not prompt identity. It covers opencodex-managed writes,
* the selected base prompt, the project documents Codex would discover from this home,
* and each skill's manifest. Plugin manifests, live MCP availability, and the clock
* also move the rendered prompt and are not files this process can name.
*
* The distinction is worth stating exactly, because the obvious phrasing is wrong: for
* a COVERED input the key moves and a late caller is refused with `busy`. For an
* UNCOVERED one the key does not move, so a late caller joins and reads the older
* rendering. That is the residual, bounded to one in-flight window in a read-only view.
*
* "Hash every input" is only closable against a pinned Codex — the dependency graph is
* upstream's and moves on its own. An enumeration-free alternative exists (admit only
* when the probe started after the request arrived) and is recorded in the plan; it
* costs the coalescing this work exists to provide unless arrivals are batched first.
* See devlog/_plan/260829_bugpr_lane_h_residual_issues/130_pr2872_probe_fingerprint.md.
*/
export function computePromptProbeStateFingerprint(opts?: Paths): string {
const configBytes = readFileOrNull(activeConfigPath(opts));
const storeBytes = readFileOrNull(activeStorePath(opts));
const variants = readBaseVariants(opts);
const selection = resolveBaseSelection(configBytes, variants, opts);
const hash = createHash("sha256");
updateFingerprintField(hash, "revision", computeRevision(configBytes, storeBytes));
updateFingerprintField(hash, "selected-base", selection.kind === "variant" ? `variant:${selection.id}` : selection.kind);
if (selection.kind === "variant") {
updateFingerprintField(hash, "variant-bytes", readFileOrNull(join(activeBaseVariantDir(opts), `${selection.id}.md`)));
}
if (selection.kind === "external") {
// The selected base file is hashed whether or not we manage it. Hashing the
// managed variant's bytes while recording an external selection as the bare
// word "external" would make the guarantee depend on who authored the file,
// which is not a distinction the probe's caller can see.
//
// Its path is part of the identity as well as its contents: pointing the key
// at a different file changes the prompt even when both files read alike.
updateFingerprintField(hash, "external-path", selection.path);
let externalBytes: string | null = null;
try {
// Relative to the CONFIG FILE's directory, which is what Codex does with its
// relative path fields. resolve() alone would use this process's cwd — the
// proxy's working directory, which has nothing to do with either the config
// or the probe child's cwd — and would hash an unrelated file.
externalBytes = readFileOrNull(resolve(dirname(activeConfigPath(opts)), expandUserPath(selection.path)));
} catch {
// An unresolvable path is a state, not a failure: it hashes as absent, and
// resolveBaseSelection has already reported the selection as external.
externalBytes = null;
}
updateFingerprintField(hash, "external-bytes", externalBytes);
}
// Codex prefers AGENTS.override.md over AGENTS.md, so both spellings are hashed
// in that order: an override edit changes the rendered project document exactly
// as a plain edit does.
const probeHome = resolveCodexHomeDir();
const filenames = probeInstructionFilenames(configBytes);
for (const dir of probeProjectDocDirs(probeHome, configBytes)) {
for (const name of filenames) {
// The path goes in the CONTENTS, never in the field name. Only contents are
// length-framed, so a name built from a path would reintroduce exactly the
// ambiguity this helper exists to remove. Path and bytes are separate fields
// because two directories in the walk can both hold an AGENTS.md.
const path = join(dir, name);
updateFingerprintField(hash, "doc-path", path);
updateFingerprintField(hash, "doc-bytes", readFileOrNull(path));
}
}
for (const path of probeSkillManifests(probeHome)) {
updateFingerprintField(hash, "skill-path", path);
updateFingerprintField(hash, "skill-bytes", readFileOrNull(path));
}
return `sha256:${hash.digest("hex")}`;
}
/**
* `SKILL.md` manifests under the home's skills directory.
*
* These were written off as unobservable in an earlier version of this function's
* comment. They are not: Codex reads each manifest's frontmatter and renders its
* description into `<skills_instructions>`, and a review round demonstrated a live
* description edit changing the probe's output while the fingerprint stood still.
*
* One directory listing plus one `readFileOrNull` per skill, beside a subprocess that
* costs orders of magnitude more. Sorted, because `readdirSync` order is not a
* contract and a digest must not depend on it.
*
* Only the top-level manifest per skill is read. A skill's bundled scripts and
* references do not reach the rendered section, so hashing the whole tree would buy
* redundant invalidations at a real cost on large skill sets.
*/
function probeSkillManifests(home: string): string[] {
const root = join(home, "skills");
let entries: string[];
try {
entries = readdirSync(root);
} catch {
return [];
}
const manifests: string[] = [];
for (const entry of entries.sort()) {
const manifest = join(root, entry, "SKILL.md");
if (existsSync(manifest)) manifests.push(manifest);
}
return manifests;
}
// ---------------------------------------------------------------------------
// Writing
// ---------------------------------------------------------------------------
export type WriteError =
| "config_unreadable"
| "stale_revision"
| "developer_instructions_not_owned"
| "unknown_layer"
| "store_unreadable"
| "invalid_characters"
| "body_too_large"
| "write_superseded"
// The filesystem refused a rename that passed every precondition: a directory on
// the store path, a mode change, a full disk. Distinct from write_superseded,
// which means another writer won a race — here nobody won and nothing landed.
| "write_failed"
| "recovery_required"
| "locked"
| "unsafe"
| "import_body_changed"
/**
* A `key =` line exists but its value is a form the line editor cannot
* replace or remove safely (a multi-line string span, an unterminated
* quote). Refused before the transaction wrote anything.
*/
| "unsupported_form";
export type WriteResult =
| { ok: true; changed: boolean; snapshot: PromptLayerSnapshot }
| { ok: false; error: WriteError; detail?: string };
function serializeStore(layers: readonly CustomLayer[]): string {
return `${JSON.stringify({ layers }, null, 2)}\n`;
}
interface Mutation {
nextConfig: string | null;
nextStore: string | null;
}
/**
* The seven-step transaction. Every filesystem mutation in this module goes
* through here so the journal, the lock, and the per-target byte checks cannot
* be bypassed by a future caller.
*/
function commit(
opts: Paths | undefined,
revision: string,
build: (snapshot: PromptLayerSnapshot, configBytes: string | null, storeBytes: string | null)
=> Mutation | { error: WriteError; detail?: string },
): WriteResult {
for (const path of [activeConfigPath(opts), activeStorePath(opts)]) prepareCodexHome(dirname(path), 0o700);
return commitPrepared(opts, revision, build);
}
function commitPrepared(
opts: Paths | undefined,
revision: string,
build: (snapshot: PromptLayerSnapshot, configBytes: string | null, storeBytes: string | null)
=> Mutation | { error: WriteError; detail?: string },
): WriteResult {
const configPath = activeConfigPath(opts);
const storePath = activeStorePath(opts);
const journalPath = journalPathFor(storePath);
const lockPath = lockPathFor(storePath);
const acquired = tryAcquire(lockPath);
if (!acquired.ok) return { ok: false, error: acquired.error, ...(acquired.error === "unsafe" ? { detail: configWriteLockFailureMessage(acquired) } : {}) };
const handle = acquired.handle;
try {
// Store -> config; cleanup protection starts before config acquisition.
const configLocked = withConfigWriteLockHeld(configPath, undefined, configHandle => {
watchConfigWriteTargets(configHandle, [storePath, journalPath]);
// 1. recovery first: a journal on disk means an earlier attempt never
// committed, and we must not stack a second transaction on top of it.
const recovered = recoverJournal(journalPath, { configPath, storePath }, configHandle);
if (!recovered.ok) return { ok: false, error: recovered.error, detail: recovered.detail };
// 2. re-read and compare against the caller's edit base.
const configBytes = readFileOrNull(configPath);
const storeBytes = readFileOrNull(storePath);
if (existsSync(configPath) && configBytes === null) {
return { ok: false, error: "config_unreadable" };
}
if (computeRevision(configBytes, storeBytes) !== revision) {
return { ok: false, error: "stale_revision" };
}
const snapshot = readPromptLayers({ ...opts, configPath, storePath });
let built: Mutation | { error: WriteError; detail?: string };
try {
built = build(snapshot, configBytes, storeBytes);
} catch (error) {
// A line editor that cannot see the end of the value span refuses BEFORE
// the journal exists — nothing has been written, so a plain error result
// is the whole answer.
if (error instanceof UnsupportedTomlForm) {
return { ok: false, error: "unsupported_form", detail: error.message };
}
throw error;
}
if ("error" in built) return { ok: false, error: built.error, detail: built.detail };
const { nextConfig, nextStore } = built;
const configChanged = nextConfig !== configBytes;
const storeChanged = nextStore !== storeBytes;
if (!configChanged && !storeChanged) {
return { ok: true, changed: false, snapshot };
}
// 3. journal the intent. Its existence is NOT a commit.
const record: JournalRecord = {
configPath,
storePath,
preConfig: hashBytes(configBytes),
postConfig: hashBytes(nextConfig),
preStore: hashBytes(storeBytes),
postStore: hashBytes(nextStore),
preConfigBytes: configBytes,
postConfigBytes: nextConfig,
preStoreBytes: storeBytes,
postStoreBytes: nextStore,
};
publishConfigWriteTarget(configPath, configHandle, journalPath, (destination, hooks) => durableWrite(destination, encodeJournal(record), hooks));
// 4/5. each target re-verifies ITS OWN bytes immediately before its rename,
// so a third party writing between step 2 and here is not overwritten.
//
// Wrapped, because a THROW here used to escape the transaction entirely.
// Only `config` readability is pre-checked, so an unwritable STORE — a
// directory sitting on its path, a permission change, a full disk — raised
// out of `durableWrite` after the config had already been renamed into
// place. The caller saw an exception, the config carried a projection whose
// store did not exist, and the journal stayed behind claiming an
// uncommitted intent. Every later write then failed recovery_required.
//
// Rolling back on the way out restores the pre-state we recorded and drops
// the journal, so a failed write leaves the pair exactly as it was found.
try {
if (configChanged) {
if (hashBytes(readFileOrNull(configPath)) !== record.preConfig) {
return rollback(record, journalPath, "stale_revision", configHandle);
}
publishConfigWrite(configPath, configHandle, (destination, hooks) => {
if (nextConfig === null) durableDelete(destination, expectingImage(hooks, record.preConfig));
else durableWrite(destination, nextConfig, expectingImage(hooks, record.preConfig));
});
}
if (storeChanged) {
if (hashBytes(readFileOrNull(storePath)) !== record.preStore) {
return rollback(record, journalPath, "stale_revision", configHandle);
}
publishConfigWriteTarget(configPath, configHandle, storePath, (destination, hooks) => {
if (nextStore === null) durableDelete(destination, expectingImage(hooks, record.preStore));
else durableWrite(destination, nextStore, expectingImage(hooks, record.preStore));
});
}
} catch (error) {
// `rollback` is byte-hash driven and refuses to touch a file it does not
// recognise, so it is safe to run against a partially applied pair. If it
// cannot account for what it finds it returns recovery_required, which is the
// honest answer — better than a silent half-write either way.
const undone = rollback(record, journalPath, "write_failed", configHandle);
return { ...undone, detail: error instanceof Error ? error.message : String(error) } as WriteResult;
}
// 6. verify COMPLETE bytes, not just our two lines: another writer could
// change an unrelated key and a narrow check would report success.
const finalConfig = hashBytes(readFileOrNull(configPath));
const finalStore = hashBytes(readFileOrNull(storePath));
if (finalConfig !== record.postConfig || finalStore !== record.postStore) {
return { ok: false, error: "write_superseded" };
}
if (!stillHeld(handle) || !stillHeld(configHandle)) return { ok: false, error: "write_superseded" };
publishConfigWriteTarget(configPath, configHandle, journalPath, (destination, hooks) => durableDelete(destination, hooks)); // this deletion is the commit
// The FULL opts, not just the two paths this transaction owns: rebuilding the
// snapshot from a narrowed object dropped the injected variant directory, so every
// successful write reported an empty variant list back to its caller.
return { ok: true, changed: true, snapshot: readPromptLayers({ ...opts, configPath, storePath }) };
});
return configLocked.ok ? configLocked.value as WriteResult : { ok: false, error: configLocked.error === "locked" ? "locked" : "unsafe", ...(configLocked.error !== "locked" ? { detail: configWriteLockFailureMessage(configLocked) } : {}) };
} finally { release(handle); }
}
/** Undo whatever landed, then drop the journal. Never touches an unknown file. */
function rollback(record: JournalRecord, journalPath: string, error: WriteError, held: LockHandle): WriteResult {
try {
const configNow = hashBytes(readFileOrNull(record.configPath));
const storeNow = hashBytes(readFileOrNull(record.storePath));
if (configNow !== record.preConfig && configNow !== record.postConfig) {
return { ok: false, error: "recovery_required", detail: record.configPath };
}
if (storeNow !== record.preStore && storeNow !== record.postStore) {
return { ok: false, error: "recovery_required", detail: record.storePath };
}
if (configNow === record.postConfig) {
publishConfigWrite(record.configPath, held, (destination, hooks) => {
if (record.preConfigBytes === null) durableDelete(destination, expectingImage(hooks, record.postConfig));
else durableWrite(destination, record.preConfigBytes, expectingImage(hooks, record.postConfig));
});
}
if (storeNow === record.postStore) {
publishConfigWriteTarget(record.configPath, held, record.storePath, (destination, hooks) => {
if (record.preStoreBytes === null) durableDelete(destination, expectingImage(hooks, record.postStore));
else durableWrite(destination, record.preStoreBytes, expectingImage(hooks, record.postStore));
});
}
publishConfigWriteTarget(record.configPath, held, journalPath, (destination, hooks) => durableDelete(destination, hooks));
return { ok: false, error };
} catch { return { ok: false, error: "recovery_required" }; }
}
/**
* Flip one of the five prompt toggles, or REMOVE its key with `enabled: null`.
*
* Removal is the "restore default" verb. A toggle's documented default lives in
* Codex, not in this file: writing `key = true` for a layer whose default is
* true produces the same prompt today but freezes the override - an upstream
* change to the default would then never reach this user. Deleting the line is
* the only state that keeps following it.
*/
export function setToggle(id: string, enabled: boolean | null, revision: string, opts?: Paths): WriteResult {
if (!isToggleId(id)) return { ok: false, error: "unknown_layer" };
const spec = TOGGLE_KEYS[id];
return commit(opts, revision, (_snapshot, configBytes, storeBytes) => ({
nextConfig: spec.table
? setTableBool(configBytes ?? "", spec.table, spec.key, enabled)
: setRootBool(configBytes ?? "", spec.key, enabled),
nextStore: storeBytes,
}));
}
/**
* Point `model_instructions_file` at a variant, or remove it for the default.
*
* Refusals, each for a reason the GUI cannot be trusted to enforce alone:
* - an unknown variant id, because the key would name a file Codex cannot read;
* - the `external` state, because retargeting a key somebody else set silently
* discards their base prompt. Adopting it is a separate, explicit act.
*/
export function selectBaseVariant(selection: BaseSelection, revision: string, opts?: Paths): WriteResult {
if (selection.kind === "external") return { ok: false, error: "unknown_layer", detail: "cannot select the external state" };
const dir = activeBaseVariantDir(opts);
return commit(opts, revision, (snapshot, configBytes, storeBytes) => {
if (snapshot.baseSelection.kind === "external") {
return { error: "developer_instructions_not_owned", detail: snapshot.baseSelection.path };
}
if (selection.kind === "variant") {
const variant = snapshot.baseVariants.find(v => v.id === selection.id);
if (!variant) return { error: "unknown_layer", detail: selection.id };
}
const next = selection.kind === "default"
? null
: resolve(join(dir, `${selection.id}.md`));
return {
nextConfig: setRootString(configBytes ?? "", "model_instructions_file", next),
nextStore: storeBytes,
};
});
}
/** How many authored variants a user may keep. Two plus the default is the ask. */
export const MAX_BASE_VARIANTS = 2;
/**
* Write or delete one authored variant body.
*
* Ordering is deliberate and was learned from a defect in this same module: the FILE is
* written and verified before `config.toml` is ever pointed at it. Pointing first would
* leave the key naming a file that may not exist, which is a worse failure than a written
* file nothing references yet.
*
* Deleting the variant that is currently SELECTED also clears the key in the same
* transaction, so the config can never outlive the file it names.
*/
export function writeBaseVariant(
input: { id: string | null; title: string; body: string } | { id: string; delete: true },
revision: string,
opts?: Paths,
): WriteResult {
const dir = activeBaseVariantDir(opts);
const deleting = "delete" in input;
if (!deleting) {
const normalized = normalizeBody(input.body);
const invalid = findInvalidCharacter(normalized);
if (invalid !== null) {
return { ok: false, error: "invalid_characters", detail: `at code point ${invalid.position}` };
}
}
const existing = readBaseVariants(opts);
const targetId = deleting
? input.id
: input.id ?? newBaseVariantId(existing);
if (!BASE_VARIANT_ID.test(targetId)) return { ok: false, error: "unknown_layer", detail: targetId };
// A caller-supplied id is an edit (or delete), never an alternate create path.
// Requiring it to exist keeps the generated-id path as the sole place where a
// new variant can enter, and therefore makes the cap impossible to bypass.
if (input.id !== null && !existing.some(v => v.id === targetId)) {
return { ok: false, error: "unknown_layer", detail: targetId };
}
if (!deleting && input.id === null && existing.length >= MAX_BASE_VARIANTS) {
return { ok: false, error: "unknown_layer", detail: `at most ${MAX_BASE_VARIANTS} variants` };
}
const path = join(dir, `${targetId}.md`);
const before = readFileOrNull(path);
const next = deleting
? null
: `# ${input.title.replace(/[\r\n]+/g, " ").trim() || targetId}\n${normalizeBody(input.body)}`;
// Whether this id is the live selection has to be decided while the file still
// EXISTS. Deleting first made `resolveBaseSelection` fall through to `external` - the
// path no longer matched a known variant - so the config half saw a state it refuses
// to touch and left the key pointing at a file that was already gone.
const selectedBefore = resolveBaseSelection(readFileOrNull(activeConfigPath(opts)), existing, opts);
const clearingKey = deleting
&& selectedBefore.kind === "variant"
&& selectedBefore.id === targetId;
// On a CREATE or EDIT the file goes first: pointing config.toml at a file that does
// not exist yet is worse than writing a file nothing references. On a DELETE the
// order is reversed for the same reason read the other way - the key must stop
// naming the file before the file disappears.
if (!deleting) {
ensureDir(path);
try {
durableWrite(path, next!);
} catch (error) {
return { ok: false, error: "write_failed", detail: error instanceof Error ? error.message : String(error) };
}
}
const result = commit(opts, revision, (_snapshot, configBytes, storeBytes) => ({
nextConfig: clearingKey
? setRootString(configBytes ?? "", "model_instructions_file", null)
: configBytes,
nextStore: storeBytes,
}));
if (!result.ok) {
// Undo the file half rather than leaving a variant the caller was told was not
// written. A delete has not touched the file yet, so there is nothing to undo.
if (!deleting) {
try {
if (before === null) durableDelete(path);
else durableWrite(path, before);
} catch { /* the returned error already tells the caller to look */ }
}
return result;
}
if (deleting) {
try {
durableDelete(path);
} catch (error) {
// The key is already clear, so the prompt is correct; the stale file is inert.
return { ok: false, error: "write_failed", detail: error instanceof Error ? error.message : String(error) };
}
// Re-read so the caller sees the variant actually gone.
return { ok: true, changed: true, snapshot: readPromptLayers(opts) };
}
return result;
}
function newBaseVariantId(existing: readonly BaseVariant[]): string {
const taken = new Set(existing.map(v => v.id));
for (;;) {
const id = randomBytes(4).toString("hex").slice(0, 6);
if (!taken.has(id)) return id;
}
}
// ---------------------------------------------------------------------------
// Import — taking ownership of an externally authored model_instructions_file.
//
// The picker refuses the `external` state outright, which made it a dead end:
// the only way to manage that prompt was to delete the line by hand and retype
// the file. Import copies the external file's body into the variant directory
// and points the key at our copy — one file, so nothing upstream can edit out
// from under a stored variant.
// ---------------------------------------------------------------------------
/**
* The single-line cap on a stored variant title — the same 80 characters the
* route policy applies to custom-layer titles. It bounds the filename-derived
* suggestion as well as any caller-supplied title, so the `# ` heading line
* the serialized variant starts with stays a bounded prefix and never swallows
* the body's byte budget silently.
*/
export const MAX_BASE_TITLE_CHARS = 80;
const IMPORT_FALLBACK_TITLE = "Imported base prompt";
/**
* Flatten a title to one line and bound it. Newlines become spaces rather than
* throwing because `readBaseVariants` reads the first line back as the title —
* a `\n` in the file would mint a second prompt line nobody asked for.
* The bound is by UTF-16 units (the same measure the route limit uses); a cut
* that lands mid-surrogate drops the dangling half so no unpaired surrogate is
* ever written.
*/
function boundTitle(raw: string | null | undefined): string | null {
if (typeof raw !== "string") return null;
const flat = raw.replace(/[\r\n]+/g, " ").trim();
if (!flat) return null;
let bounded = flat.length > MAX_BASE_TITLE_CHARS ? flat.slice(0, MAX_BASE_TITLE_CHARS) : flat;
if (/[\uD800-\uDBFF]$/.test(bounded)) bounded = bounded.slice(0, -1);
return bounded || null;
}
export interface BaseImportPreview {
/** The literal value of `model_instructions_file`, as configured. */
rawPath: string | null;
/** The absolute file the key resolves to, when it could be resolved. */
resolvedPath: string | null;
/** The normalized body — the file text after CRLF/tab normalization. */
body: string | null;
/**
* The EXACT text a confirm would write to the variant file: the effective
* title as a `# ` heading line followed by the normalized body. What the
* user previews is what Codex reads — there is no second description.
*/
serialized: string | null;
/**
* sha256 of `serialized`, and REQUIRED on confirm. The hash covers the title
* line as well as the body, so a confirmation is bound to the exact text —
* including the selected title — the caller previewed.
*/
previewSha256: string | null;
/**
* The filename-derived title, already bounded to {@link MAX_BASE_TITLE_CHARS}
* so it is displayable and storable as-is. `null` when the path names no
* markdown file worth naming after.
*/
suggestedTitle: string | null;
/** The title `serialized` was built with: requested, suggested, or fallback. */
effectiveTitle: string | null;
reason: "ok" | "nothing_to_import" | "file_unreadable" | "invalid_characters"
| "slots_full" | "unsupported_form" | "body_too_large";
detail?: string;
}
/**
* Read-only. Runs the same steps a confirm would — resolve, read, normalize,
* title, serialize — so `serialized` is byte-identical to the stored file and
* `previewSha256` binds a confirm to exactly it.
*
* `title` is the caller's choice for the variant title; omitting it previews
* the suggested (or fallback) title. Re-preview with the edited title to get a
* hash bound to that spelling.
*
* `slots_full` still returns the serialized text: the preview is the place to
* say "this would be imported if a slot were free", and refusing to show the
* text at all would make the cap look like a read failure.
*/
export function previewBaseImport(opts?: Paths, title?: string): BaseImportPreview {
const configPath = activeConfigPath(opts);
const configBytes = readFileOrNull(configPath);
const variants = readBaseVariants(opts);
const selection = resolveBaseSelection(configBytes, variants, opts);
const empty: Omit<BaseImportPreview, "reason"> = {
rawPath: selection.kind === "external" ? selection.path : null,
resolvedPath: null,
body: null,
serialized: null,
previewSha256: null,
suggestedTitle: null,
effectiveTitle: null,
};
if (selection.kind !== "external") {
return { ...empty, reason: "nothing_to_import" };
}
// A key whose value is a form the line editor cannot replace (a multi-line
// string span, an unterminated quote) can never be retargeted — say so in the
// preview rather than let a confirm discover it inside the transaction.
if (rootKeyValueForm(configBytes ?? "", "model_instructions_file") === "unsupported") {
return {
...empty,
reason: "unsupported_form",
detail: "the model_instructions_file value is a TOML form this editor cannot rewrite (for example a multi-line string); edit config.toml by hand",
};
}
const dir = dirname(configPath);
let resolved: string;
try {
resolved = resolve(dir, expandUserPath(selection.path));
} catch {
return { ...empty, reason: "file_unreadable", detail: `the path could not be resolved: ${selection.path}` };
}
let raw: string;
try {
raw = readBaseImportSource(resolved);
} catch (error) {
const oversized = (error as NodeJS.ErrnoException).code === "EFBIG";
return { ...empty, resolvedPath: resolved,
reason: oversized ? "body_too_large" : "file_unreadable",
detail: oversized ? "the file body exceeds 65536 bytes" : `could not read ${resolved}` };
}
const normalized = normalizeBody(raw);
if (Buffer.byteLength(normalized, "utf8") > 64 * 1024) {
return { ...empty, resolvedPath: resolved, reason: "body_too_large", detail: "the file body exceeds 65536 bytes" };
}
const invalid = findInvalidCharacter(normalized);
if (invalid !== null) {
return {
...empty,
resolvedPath: resolved,
reason: "invalid_characters",
detail: `code point ${invalid.position} is a ${invalid.reason}`,
};
}
const suggestedTitle = boundTitle(resolved.replace(/\\/g, "/").split("/").pop()!
.replace(/\.(md|markdown|txt)$/i, ""));
const effectiveTitle = boundTitle(title) ?? suggestedTitle ?? IMPORT_FALLBACK_TITLE;
const serialized = `# ${effectiveTitle}\n${normalized}`;
return {
rawPath: selection.path,
resolvedPath: resolved,
body: normalized,
serialized,
previewSha256: createHash("sha256").update(serialized, "utf8").digest("hex"),
suggestedTitle,
effectiveTitle,
reason: variants.length >= MAX_BASE_VARIANTS ? "slots_full" : "ok",
};
}
/**
* True when the config still names this variant — or when nothing can be
* proved either way. An unreadable config returns true because "the file is
* unreferenced" must be ESTABLISHED, not assumed: deleting a variant a live
* `model_instructions_file` points at strands the prompt in force.
*/
function variantStillReferenced(id: string, path: string, opts?: Paths): boolean {
const configBytes = readFileOrNull(activeConfigPath(opts));
if (configBytes === null) return true;
const selection = resolveBaseSelection(configBytes, readBaseVariants(opts), opts);
if (selection.kind === "variant") return selection.id === id;
if (selection.kind !== "external") return false;
let selected: string;
try {
selected = resolve(dirname(activeConfigPath(opts)), expandUserPath(selection.path));
} catch {
return true;
}
if (selected === resolve(path)) return true;
// A lexical match is not the only way to name the file: a symlink (or a
// symlinked directory) resolves to it too, and resolve() does not follow
// links. Compare canonical destinations. Only a selection that provably does
// not exist rules the copy out; any other failure keeps it.
try {
return realpathSync(selected) === realpathSync(path);
} catch (error) {
return (error as NodeJS.ErrnoException).code !== "ENOENT";
}
}
/**
* Copy the external file into the variant directory and retarget the key at it.
*
* Same ordering as `writeBaseVariant` and for the same reason: the .md is
* written and verified before `config.toml` is ever pointed at it, and if the
* transaction refuses, the file is deleted rather than left behind for a write
* the caller was told did not happen — but ONLY when the refusal proves no
* config references it. `write_superseded` and `recovery_required` can return
* after the post-write state was applied or while its shape is unknown; in
* that uncertainty the file AND the recovery evidence (the journal commit()
* left behind) are preserved.
*
* `previewSha256` is REQUIRED — the hash binds the exact serialized text the
* caller previewed, title line included, and a confirm without it (or one the
* current file no longer matches) is refused without writing.
*
* The `external` state is RE-CHECKED inside the transaction. Between the
* preview and the commit another writer could have adopted or cleared the key,
* and silently repointing then would claim an import nobody asked for.
*/
export function importBaseVariant(
input: { title?: string; previewSha256?: string },
revision: string,
opts?: Paths,
): WriteResult {
const preview = previewBaseImport(opts, input.title);
if (preview.body === null || preview.serialized === null || preview.previewSha256 === null) {
return {
ok: false,
error: preview.reason === "invalid_characters" ? "invalid_characters"
: preview.reason === "body_too_large" ? "body_too_large"
: preview.reason === "unsupported_form" ? "unsupported_form"
: "developer_instructions_not_owned",
detail: preview.detail,
};
}
if (typeof input.previewSha256 !== "string" || input.previewSha256 !== preview.previewSha256) {
// The caller confirmed text they previewed; a different file, or a
// different title, today is a different import they never saw — and a
// missing hash means nothing was previewed at all. Refuse rather than
// install a surprise.
return { ok: false, error: "import_body_changed", detail: "the preview no longer matches; preview it again" };
}
// Even with a matching hash, refuse BEFORE writing the variant file when the
// configured key is a form the line editor cannot retarget — the preview
// reported the same reason, so a caller that confirmed anyway hears it too.
if (rootKeyValueForm(readFileOrNull(activeConfigPath(opts)) ?? "", "model_instructions_file") === "unsupported") {
return { ok: false, error: "unsupported_form", detail: preview.detail };
}
const dir = activeBaseVariantDir(opts);
const existing = readBaseVariants(opts);
if (existing.length >= MAX_BASE_VARIANTS) {
return { ok: false, error: "unknown_layer", detail: `at most ${MAX_BASE_VARIANTS} variants` };
}
const targetId = newBaseVariantId(existing);
const path = join(dir, `${targetId}.md`);
ensureDir(path);
try {
// The file written is the previewed serialization byte-for-byte: the same
// string that produced previewSha256 is what lands on disk.
durableWrite(path, preview.serialized);
} catch (error) {
return { ok: false, error: "write_failed", detail: error instanceof Error ? error.message : String(error) };
}
const result = commit(opts, revision, (snapshot, configBytes, storeBytes) => {
if (snapshot.baseSelection.kind !== "external") {
return { error: "developer_instructions_not_owned", detail: "model_instructions_file no longer points at an external file" };
}
// The hash check above ran before either write lock was held, so the source
// could have been rewritten while the locks were being acquired. Re-read it
// now, under both locks, and refuse unless it still serializes to exactly
// what the caller previewed: activating an older copy of a file that has
// since changed is the surprise the preview hash exists to prevent.
const recheck = previewBaseImport(opts, input.title);
if (recheck.previewSha256 !== preview.previewSha256 || recheck.resolvedPath !== preview.resolvedPath) {
return { error: "import_body_changed", detail: "the source changed while the import was being confirmed; preview it again" };
}
return {
nextConfig: setRootString(configBytes ?? "", "model_instructions_file", resolve(path)),
nextStore: storeBytes,
};
});
if (!result.ok) {
// The copy is deleted only once the live config is shown not to reference
// it, whatever the refusal. `write_superseded`/`recovery_required` can
// return after the post-write state was applied, and even a refusal that
// wrote nothing (the locked recheck above, a stale revision) cannot rule
// out a non-cooperating writer having selected the visible copy in the
// meantime. Deleting a file a live config points at strands the prompt in
// force, which is the data loss the refusal was protecting against.
if (!variantStillReferenced(targetId, path, opts)) {
try {
durableDelete(path);
} catch { /* the returned error already tells the caller to look */ }
}
return result;
}
// commit()'s success path already re-reads the full snapshot with the injected
// variant directory, so the result lists the file just written.
return result;
}
/** Replace the whole custom-layer list; order is composition order. */
export function writeCustomLayers(layers: readonly CustomLayer[], revision: string, opts?: Paths): WriteResult {
for (const layer of layers) {
const normalized = normalizeBody(layer.body);
const invalid = findInvalidCharacter(normalized);
if (invalid !== null) {
return { ok: false, error: "invalid_characters", detail: `layer ${layer.id} at code point ${invalid.position}` };
}
}
const normalizedLayers = layers.map(l => ({ ...l, body: normalizeBody(l.body) }));
return commit(opts, revision, (snapshot, configBytes, _storeBytes) => {
// Only a marker-owned key may be rewritten. Absent is fine — we create it.
const ownership = inspectOwnership(configBytes);
if (ownership.state === "external" || ownership.state === "owned-malformed") {
return { error: "developer_instructions_not_owned" };
}
const projection = composeProjection(normalizedLayers);
return {
nextConfig: setProjection(configBytes, projection.length > 0 ? projection : null),
nextStore: serializeStore(normalizedLayers),
};
});
}
// ---------------------------------------------------------------------------
// Adoption — taking ownership of an externally authored key.
//
// Refusing alone was a dead end: the earlier answer was "delete your existing
// instructions by hand", which is not a feature. Adoption previews the raw line
// AND the exact body that will be committed, then imports on confirmation.
// ---------------------------------------------------------------------------
export interface AdoptPreview {
rawLine: string | null;
/** post-normalization body — byte-identical to what a confirm would store */
decodedBody: string | null;
reason: "ok" | "nothing_to_adopt" | "unsupported_form" | "invalid_characters";
path: string;
line: number | null;
detail?: string;
}
function newLayerId(existing: readonly CustomLayer[]): string {
const taken = new Set(existing.map(l => l.id));
for (;;) {
const id = randomBytes(4).toString("hex").slice(0, 6);
if (!taken.has(id)) return id;
}
}
/**
* Read-only. Runs the same five steps a confirm would, so preview and commit
* cannot disagree: decode -> normalize -> validate -> cap -> present.
*/
export function previewAdopt(opts?: Paths): AdoptPreview {
const configPath = activeConfigPath(opts);
const ownership = inspectOwnership(readFileOrNull(configPath));
if (ownership.state === "absent" || ownership.state === "owned") {
return { rawLine: null, decodedBody: null, reason: "nothing_to_adopt", path: configPath, line: null };
}
const raw = ownership.raw;
const line = ownership.line;
const eq = raw.indexOf("=");
const literal = eq === -1 ? "" : raw.slice(eq + 1).trim().replace(/\s*#.*$/, "");
const decoded = decodeBasicString(literal);
if (decoded === null) {
return {
rawLine: raw,
decodedBody: null,
reason: "unsupported_form",
path: configPath,
line,
detail: "only a single-line basic string using \\\", \\\\ and \\n can be decoded safely",
};
}
const normalized = normalizeBody(decoded);
const invalid = findInvalidCharacter(normalized);
if (invalid !== null) {
return {
rawLine: raw,
decodedBody: null,
reason: "invalid_characters",
path: configPath,
line,
detail: `code point ${invalid.position} is a ${invalid.reason}`,
};
}
return { rawLine: raw, decodedBody: normalized, reason: "ok", path: configPath, line };
}
/** Import the external value as one custom layer and take ownership of the key. */
export function adoptDeveloperInstructions(revision: string, opts?: Paths): WriteResult {
const preview = previewAdopt(opts);
if (preview.reason !== "ok" || preview.decodedBody === null) {
return {
ok: false,
error: preview.reason === "invalid_characters" ? "invalid_characters" : "developer_instructions_not_owned",
detail: preview.detail,
};
}
const body = preview.decodedBody;
return commit(opts, revision, (snapshot, configBytes) => {
const existing = snapshot.custom;
const adopted: CustomLayer = {
id: newLayerId(existing),
title: "Imported from config.toml",
body,
enabled: true,
};
const layers = [adopted, ...existing];
// Drop the unowned line first, then write the canonical owned block.
const stripped = removeUnownedProjection(configBytes ?? "");
return {
nextConfig: setProjection(stripped, composeProjection(layers)),
nextStore: serializeStore(layers),
};
});
}
// ---------------------------------------------------------------------------
// Salvage — the store is gone while a live projection remains.
//
// This is salvage, NOT reconstruction. The projection is one concatenated
// string: layer boundaries, ids, titles, order, disabled layers, and whether a
// blank line separated two layers or was the user's own text are all gone.
// ---------------------------------------------------------------------------
export interface SalvagePreview {
body: string | null;
/** the DIRECTORY backups land in. A read-only preview reserves no filename. */
backupDir: string;
unrecoverable: readonly string[];
reason: "ok" | "nothing_to_salvage";
}
const UNRECOVERABLE = Object.freeze([
"layer boundaries",
"layer ids",
"layer titles",
"row order",
"disabled layers and their bodies",
"whether a blank line separated two layers or was your own text",
]);
export function previewSalvage(opts?: Paths): SalvagePreview {
const configPath = activeConfigPath(opts);
const storePath = activeStorePath(opts);
const ownership = inspectOwnership(readFileOrNull(configPath));
const body = ownership.state === "owned" ? decodeBasicString(ownership.literal) : null;
return {
body,
// `dirname`, not a hand-rolled `lastIndexOf("/")`: a Windows store path is
// `D:\...\store.toml`, which contains no forward slash at all, so the
// slice returned `"."` and the preview named the wrong directory.
backupDir: dirname(storePath),
unrecoverable: UNRECOVERABLE,
reason: body !== null && body.length > 0 ? "ok" : "nothing_to_salvage",
};
}
/**
* Adopt the live projection as ONE layer. A durable backup is written first and
* salvage aborts if it cannot be created — a destructive operation whose safety
* net failed should not proceed.
*/
export function salvageProjection(revision: string, opts?: Paths): WriteResult {
const preview = previewSalvage(opts);
if (preview.reason !== "ok" || preview.body === null) {
return { ok: false, error: "developer_instructions_not_owned", detail: "no live projection to salvage" };
}
const body = preview.body;
const storePath = activeStorePath(opts);
const backupPath = `${storePath.replace(/\.json$/, "")}.salvage-${Date.now()}-${randomBytes(3).toString("hex")}.txt`;
try {
durableWriteExclusive(backupPath, body);
} catch {
return { ok: false, error: "recovery_required", detail: `could not write a durable backup at ${backupPath}` };
}
return commit(opts, revision, (_snapshot, configBytes) => {
const salvaged: CustomLayer = {
id: newLayerId([]),
title: "Salvaged from config.toml",
body,
enabled: true,
};
return {
nextConfig: setProjection(configBytes, body),
nextStore: serializeStore([salvaged]),
};
});
}
/**
* Recovery as a first-class operation, under the same file lock every mutation
* takes. This is the journal-present repair: it replays the journal and writes
* NOTHING else.
*
* A byte-identical PUT used to stand in for it, and it was not safe. When the
* store file is missing, the snapshot's custom list reads [], so the "no-op"
* write projected an empty developer_instructions over whatever the config
* still carried — surviving instructions erased by the very repair that was
* supposed to touch nothing. Recovery alone preserves exactly the bytes it can
* account for — post where the pair proves the commit landed, pre where it
* proves it did not — and refuses rather than guess when a target matches
* neither image.
*/
export function recoverPromptJournal(opts?: Paths): WriteResult {
const configPath = activeConfigPath(opts);
const storePath = activeStorePath(opts);
const journalPath = journalPathFor(storePath);
for (const path of [configPath, storePath]) prepareCodexHome(dirname(path), 0o700);
const acquired = tryAcquire(lockPathFor(storePath));
if (!acquired.ok) return { ok: false, error: acquired.error, ...(acquired.error === "unsafe" ? { detail: configWriteLockFailureMessage(acquired) } : {}) };
const handle = acquired.handle;
try {
// Use the canonical destination witness and explicit held handle used by
// normal commits; journal replay must not reacquire its own live lock.
const configLocked = withConfigWriteLockHeld(configPath, undefined, configHandle => {
watchConfigWriteTargets(configHandle, [storePath, journalPath]);
const recovered = recoverJournal(journalPath, { configPath, storePath }, configHandle);
if (!recovered.ok) return { ok: false, error: recovered.error, detail: recovered.detail };
return {
ok: true,
// Action "none" means there was no journal to close or replay.
changed: recovered.action !== "none",
snapshot: readPromptLayers({ ...opts, configPath, storePath }),
};
});
return configLocked.ok ? configLocked.value as WriteResult : { ok: false, error: configLocked.error === "locked" ? "locked" : "unsafe", ...(configLocked.error !== "locked" ? { detail: configWriteLockFailureMessage(configLocked) } : {}) };
} finally { release(handle); }
}