@ammar-ahmed/automation-app-bot/__tests__/unit/validators/options_processor/owners.test.js

Automation made easy and fun OH Yeah!

const Helper = require('../../../../__fixtures__/unit/helper')
const owners = require('../../../../lib/validators/options_processor/owners')
const teams = require('../../../../lib/validators/options_processor/teams')

jest.mock('../../../../lib/validators/options_processor/teams', () => ({
  extractTeamMemberships: jest.fn()
}))

test('that * works', async () => {
  const codeowner = '* @bob'
  let commitDiffs = createCommitDiffs(['first/second/third/dir/test.js'])

  let res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))

  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')

  commitDiffs = createCommitDiffs(['another/file/path/test.js'])

  res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')
})

test('that *.js (fileType) works', async () => {
  let codeowner = '*.js @bob'
  let commitDiffs = createCommitDiffs(['first/second/third/dir/test.js'])

  let res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')

  codeowner = '*.go @bob'
  commitDiffs = createCommitDiffs(['another/file/path/test.js'])

  res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(0)

  codeowner = '*.go @bob'
  commitDiffs = createCommitDiffs(['another/file/path/test.go'])

  res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')
})

test('that /docs/ only matches docs directory in root', async () => {
  const codeowner = ' /docs/ @bob'
  let commitDiffs = createCommitDiffs(['/docs/test.js'])

  let res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')

  commitDiffs = createCommitDiffs(['another/file/docs/test.js'])

  res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(0)
})

test('that /docs/ only matches all files in all subdirectory', async () => {
  const codeowner = '/docs/ @bob'
  let commitDiffs = createCommitDiffs(['/docs/long/path/to/test.js'])

  let res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')

  commitDiffs = createCommitDiffs(['docs/test/anotherTest.js'])

  res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')
})

test('that /docs/* only matches all files in that directory', async () => {
  const codeowner = '/docs/* @bob'
  let commitDiffs = createCommitDiffs(['/docs/test.js'])

  let res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')

  commitDiffs = createCommitDiffs(['/docs/not/matching/test.js'])

  res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(0)
})

test('that **/docs matches all files and directories in docs/', async () => {
  const codeowner = '**/docs @bob'
  let commitDiffs = createCommitDiffs(['first/second/docs/test.js'])

  let res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')

  commitDiffs = createCommitDiffs(['first/second/docs/inside/test.js'])

  res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')
})

test('that /docs/**/apps/ matches the sub directories properly', async () => {
  const codeowner = '/docs/**/apps/ @bob'
  let commitDiffs = createCommitDiffs(['/docs/second/third/apps/test.js'])

  let res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')

  commitDiffs = createCommitDiffs(['/docs/third/apps/inside/test.js'])

  res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')
})

test('that /apps/** matches all the sub directories of app', async () => {
  const codeowner = '/apps/** @bob'
  let commitDiffs = createCommitDiffs(['/apps/second/third/dir/test.js'])

  let res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')

  commitDiffs = createCommitDiffs(['/apps/file/path/test.go'])

  res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')
})

test('that apps/ matches all instances of app/', async () => {
  const codeowner = 'apps/ @bob'
  let commitDiffs = createCommitDiffs(['first/second/third/apps/test.js'])

  let res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')

  commitDiffs = createCommitDiffs(['another/file/path/apps/test.js'])

  res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')
})

test('that rules that comes later takes higher priority', async () => {
  const codeowner = '*.js @bob \n/docs/ @hope'
  let commitDiffs = createCommitDiffs(['/docs/test.js'])

  let res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('hope')

  commitDiffs = createCommitDiffs(['another/file/path/test.js'])

  res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(1)
  expect(res[0]).toBe('bob')
})

test('teams owners are processed correctly', async () => {
  const codeowner = '*.js @bob/test-team'
  const commitDiffs = createCommitDiffs(['/docs/test.js'])

  const approvedReviewers = ['teamMember1', 'member2']
  teams.extractTeamMemberships = jest.fn().mockReturnValue(approvedReviewers)

  const res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs), approvedReviewers)
  expect(res.length).toBe(2)
  expect(res[0]).toBe('teamMember1')
  expect(res[1]).toBe('member2')
})

test('non-team member cannot approve the PR', async () => {
  const codeowner = '*.js @bob/test-team'
  const commitDiffs = createCommitDiffs(['/docs/test.js'])

  const reviewer = ['member3']
  const approvedReviewers = ['teamMember1', 'member2']
  teams.extractTeamMemberships = jest.fn().mockReturnValue(approvedReviewers)

  const res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs), approvedReviewers)
  expect(reviewer).not.toEqual(expect.arrayContaining(res))
})

test('teams owners and individuals are processed correctly', async () => {
  const codeowner = '*.js @bob/test-team @hope'
  const commitDiffs = createCommitDiffs(['/docs/test.js'])

  teams.extractTeamMemberships = jest.fn().mockReturnValue(['teamMember1', 'member2'])

  const res = await owners.process(createMockPR(), createMockContext(codeowner, commitDiffs))
  expect(res.length).toBe(3)
  expect(res[0]).toBe('teamMember1')
  expect(res[1]).toBe('member2')
  expect(res[2]).toBe('hope')
})

const createMockPR = () => {
  return Helper.mockContext({
    user: {
      login: 'creator'
    },
    number: 1
  }).payload.pull_request
}

const createCommitDiffs = (diffs) => {
  return diffs.map(diff => ({
    filename: diff
  }))
}

const createMockContext = (owners, commitDiffs, options) => {
  const context = Helper.mockContext({
    codeowners: Buffer.from(`${owners}`).toString('base64'),
    compareCommits: commitDiffs,
    files: options ? options.files : []
  })

  return context
}