@agility/cli
Version:
Agility CLI for working with your content. (Public Beta)
126 lines (89 loc) • 4.47 kB
Markdown
# Final Removal Candidate List - Phase 19.3
## 🎯 **COMPREHENSIVE ANALYSIS COMPLETE**
Based on comprehensive analysis of:
- ✅ External method usage (Task 19.1.1)
- ✅ Internal method dependencies (Task 19.1.2)
- ✅ Monolithic file references (Task 19.1.3)
- ✅ Cross-service dependencies (Task 19.2.1)
- ✅ Runner/coordinator usage (Task 19.2.2)
---
## 🗑️ **FINAL SAFE REMOVAL TARGETS: 14 Methods**
### **🥇 PRIORITY 1: Completely Unused Service Methods (7 methods)**
#### **PageChainAnalyzer** (2 methods)
1. ✅ `isPageBroken()` - never called externally or internally
2. ✅ `showPageDependencyHierarchy()` - never called (replaced by hierarchical display)
#### **ContainerReferenceExtractor** (2 methods)
3. ✅ `getContainerIdsFromPageZones()` - never called by any service
4. ✅ `findMissingContainerDependencies()` - never called by any service
#### **SourceDataLoader** (3 methods - ENTIRE SERVICE REMOVABLE)
5. ✅ `loadSourceData()` - never called (different loading pattern used)
6. ✅ `hasNoContent()` - never called anywhere
7. ✅ `validateRequiredEntities()` - never called anywhere
**Estimated Reduction**: 200-250 lines (including entire SourceDataLoader service)
---
### **🥈 PRIORITY 2: Unused Orchestration Methods (7 methods)**
#### **ComprehensiveAnalysisRunner** (3 methods)
8. ✅ `runStep()` - never called externally
9. ✅ `runSteps()` - never called externally
10. ✅ `getCoordinator()` - never called externally
#### **AnalysisStepCoordinator** (4 methods)
11. ✅ `executeSteps()` - never called
12. ✅ `getRegisteredSteps()` - only called internally by runStep (which is also unused)
13. ✅ `hasStep()` - only called internally by runStep (which is also unused)
14. ✅ `executeAllSteps()` - never called
**Estimated Reduction**: 100-150 lines
---
## ⚠️ **METHODS PRESERVED (Critical Dependencies)**
### **Previously Misidentified but Actually Needed:**
- ❌ `ModelChainAnalyzer.modelHasModelDependencies()` - KEEP (called by showModelToModelChains)
- ❌ `DependencyFinder.findMissingDependenciesForContent()` - KEEP (called by validateDependencies)
### **Heavily Used Utility Services (Cannot Remove):**
- **AssetReferenceExtractor**: All methods used by 4+ services
- **ContainerReferenceExtractor**: 2 methods used by 6+ services
- **DependencyFinder**: All remaining methods used by 4+ services
- **ModelChainAnalyzer**: Core methods used by 3+ services
- **All Chain Analysis Services**: Required by coordinator
---
## 📊 **REMOVAL EXECUTION PLAN**
### **Phase A: Service Method Cleanup (Priority 1)**
**Order**: Start with completely isolated services
1. 🎯 **SourceDataLoader** - Remove entire service (easiest, no dependencies)
2. 🎯 **ContainerReferenceExtractor** - Remove 2 unused methods
3. 🎯 **PageChainAnalyzer** - Remove 2 unused methods
**Safety**: Test compilation after each service
### **Phase B: Orchestration Cleanup (Priority 2)**
**Order**: Remove least-used methods first
4. 🎯 **AnalysisStepCoordinator** - Remove 4 unused methods
5. 🎯 **ComprehensiveAnalysisRunner** - Remove 3 unused methods
**Safety**: Test full sync functionality after orchestration changes
---
## 🧪 **VALIDATION STRATEGY**
### **After Each Phase:**
1. ✅ TypeScript compilation check
2. ✅ Import resolution verification
3. ✅ Full sync test (ensure PageID:17 still nests under PageID:16)
### **Safety Nets:**
- ✅ Git checkpoint before starting
- ✅ Progressive removal (one service at a time)
- ✅ Abort on any compilation errors
---
## 📈 **EXPECTED IMPACT**
### **Quantitative Results:**
- **Total Methods Removed**: 14
- **Total Line Reduction**: 300-400 lines
- **Services Eliminated**: 1 (SourceDataLoader)
- **File Count Reduction**: 1 service file
### **Qualitative Benefits:**
- **Reduced Complexity**: Fewer unused code paths
- **Improved Maintainability**: Only necessary code remains
- **Cleaner Architecture**: Focused service responsibilities
- **Better Performance**: Reduced memory footprint
### **Zero Functionality Loss:**
- ✅ All 6-step analysis preserved
- ✅ Hierarchical page display preserved
- ✅ Cross-service coordination preserved
- ✅ All external integrations preserved
---
## 🚦 **READY FOR EXECUTION**
All analysis complete. Ready to proceed with **Task 19.4: Systematic Cleanup Execution**.
**Recommendation**: Execute Phase A first (service method cleanup) to achieve immediate impact with minimal risk.